Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use correct host portal viewport for dropdown position #5662

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes taiga-family/editor#201

image

What is the new behaviour?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 17, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Visit the preview URL for this PR (updated for commit 5021676):

https://taiga-ui--pr5662-splincode-fix-tui-ed-up40rqq7.web.app

(expires Thu, 19 Oct 2023 12:47:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Oct 17, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
336.23KB (+38B +0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
201.19KB +10%
demo/browser/runtime.(hash).js
38.18KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +30B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (-45B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need something like that for hints too?

@splincode splincode force-pushed the splincode/fix/tui-editor/issues/201 branch from 434da06 to b1af665 Compare October 18, 2023 12:41
@splincode splincode requested a review from waterplea October 18, 2023 12:42
@splincode splincode force-pushed the splincode/fix/tui-editor/issues/201 branch from b1af665 to 5021676 Compare October 18, 2023 12:42
@splincode
Copy link
Member Author

Do we need something like that for hints too? maybe separate PR

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #5662 (5021676) into main (d27927b) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #5662   +/-   ##
=======================================
  Coverage   72.38%   72.39%           
=======================================
  Files        1448     1448           
  Lines       15776    15777    +1     
  Branches     2219     2219           
=======================================
+ Hits        11419    11421    +2     
  Misses       3995     3995           
+ Partials      362      361    -1     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.74% <ø> (ø)
core 78.19% <80.00%> (+0.03%) ⬆️
kit 70.91% <ø> (ø)
summary 72.39% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...directives/dropdown/dropdown-position.directive.ts 90.90% <80.00%> (+3.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode
Copy link
Member Author

@vladimirpotekhin hello, please review me)

@splincode splincode merged commit e90c4a4 into main Oct 20, 2023
38 checks passed
@splincode splincode deleted the splincode/fix/tui-editor/issues/201 branch October 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Окно редактирования ссылки
3 participants