-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use correct host portal viewport for dropdown position #5662
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 5021676): https://taiga-ui--pr5662-splincode-fix-tui-ed-up40rqq7.web.app (expires Thu, 19 Oct 2023 12:47:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +30B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need something like that for hints too?
projects/core/directives/dropdown/dropdown-position.directive.ts
Outdated
Show resolved
Hide resolved
projects/core/directives/dropdown/dropdown-position.directive.ts
Outdated
Show resolved
Hide resolved
projects/core/directives/dropdown/dropdown-position.directive.ts
Outdated
Show resolved
Hide resolved
434da06
to
b1af665
Compare
b1af665
to
5021676
Compare
|
Codecov Report
@@ Coverage Diff @@
## main #5662 +/- ##
=======================================
Coverage 72.38% 72.39%
=======================================
Files 1448 1448
Lines 15776 15777 +1
Branches 2219 2219
=======================================
+ Hits 11419 11421 +2
Misses 3995 3995
+ Partials 362 361 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@vladimirpotekhin hello, please review me) |
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes taiga-family/editor#201
What is the new behaviour?