Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout): CardLarge remove Cell negative margins and fix by spec #9034

Closed
wants to merge 4 commits into from
Closed

fix(layout): CardLarge remove Cell negative margins and fix by spec #9034

wants to merge 4 commits into from

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 15, 2024

Close #

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 15, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit c9c5c06):

https://taiga-previews--pr9034-mdlufy-card-tynj2hi0.web.app

(expires Mon, 16 Sep 2024 19:19:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 15, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 285.19KB (-410B -0.14%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 216.46KB +10%
✅ demo/browser/runtime.(hash).js
 42.28KB +10%
✅ demo/browser/styles.(hash).css
 12.83KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

Total files change -407B -0.07%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.01MB (-106B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@mdlufy mdlufy force-pushed the mdlufy/card branch 2 times, most recently from bc18674 to 2ee32c3 Compare September 15, 2024 18:21
@mdlufy mdlufy marked this pull request as draft September 16, 2024 09:06
@mdlufy
Copy link
Collaborator Author

mdlufy commented Sep 17, 2024

Сlosed in favor #9040

@mdlufy mdlufy closed this Sep 17, 2024
@splincode splincode deleted the mdlufy/card branch September 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@mdlufy mdlufy

Labels
v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlufy @splincode