Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable arguments-order #9035

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor: enable arguments-order #9035

merged 1 commit into from
Sep 17, 2024

Conversation

splincode
Copy link
Member

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 15, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 label Sep 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit b03db9b):

https://taiga-previews--pr9035-splincode-eslint-arg-k6ayxw8j.web.app

(expires Mon, 16 Sep 2024 18:52:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 15, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 285.59KB +10%
✅ demo/browser/vendor.(hash).js
 216.46KB +10%
✅ demo/browser/runtime.(hash).js
 42.27KB +10%
✅ demo/browser/styles.(hash).css
 12.82KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.01MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode merged commit c13e925 into main Sep 17, 2024
31 checks passed
@splincode splincode deleted the splincode/eslint-arguments-order branch September 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@mdlufy mdlufy mdlufy approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@splincode splincode

Labels
ready to merge v4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @waterplea @mdlufy