Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): support provide custom query selector for auto focus directive #9062

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(cdk): support provide custom query selector for auto focus directive #9062

merged 1 commit into from
Sep 19, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Sep 17, 2024 •
edited by hakimio
Loading

image

Close #9092

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 17, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2fc2a2d):

https://taiga-previews--pr9062-splincode-fix-editor-phqh7nlb.web.app

(expires Fri, 20 Sep 2024 12:31:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 17, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 287.26KB (+36B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 247.15KB +10%
✅ demo/browser/runtime.(hash).js
 42.32KB +10%
✅ demo/browser/styles.(hash).css
 16.19KB +10%
✅ demo/browser/polyfills.(hash).js
 11.2KB +10%

Total files change +36B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.05MB (+36B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode mentioned this pull request Sep 19, 2024
Closed
@splincode splincode force-pushed the splincode/fix/editor branch 4 times, most recently from 502aa0a to 31e558a Compare September 19, 2024 12:10
@splincode splincode enabled auto-merge (squash) September 19, 2024 12:28
@splincode splincode merged commit ae149f5 into main Sep 19, 2024
28 checks passed
@splincode splincode deleted the splincode/fix/editor branch September 19, 2024 12:44
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@hakimio hakimio hakimio approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@splincode splincode

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - [v4] AutoFocus does not work with tui-editor
4 participants
@splincode @hakimio @waterplea @mdlufy