-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo): correct templateRef option in icon dropdown for inputCardG… #9124
chore(demo): correct templateRef option in icon dropdown for inputCardG… #9124
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9124 +/- ##
==========================================
- Coverage 75.68% 75.28% -0.40%
==========================================
Files 1216 1233 +17
Lines 19068 19327 +259
Branches 2091 2053 -38
==========================================
+ Hits 14432 14551 +119
- Misses 4592 4736 +144
+ Partials 44 40 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
21c1b1f
to
3581729
Compare
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +20B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fix it differently and instead just add instanceof TemplateRef check in the docs to display "TemplateRef" instead of invoking toString
Thanks for the suggestion @waterplea, I have resolved the PR comment. Please check. |
I meant to change it across all docs, not in this particular case. You can add a check here: return value instanceof TemplateRef ? 'TemplateRef' : tuiInspectAny(value, depth); This way it will be fixed for such cases across all of the demo portal |
Thanks @waterplea, Suggestion was helpful and i have made the changes accordingly. |
Close #9054