Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): correct templateRef option in icon dropdown for inputCardG… #9124

Merged

Conversation

shiv9604
Copy link
Contributor

Close #9054

Copy link

lumberjack-bot bot commented Sep 21, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (4a26b1a) to head (9fdd72f).
Report is 320 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9124      +/-   ##
==========================================
- Coverage   75.68%   75.28%   -0.40%     
==========================================
  Files        1216     1233      +17     
  Lines       19068    19327     +259     
  Branches     2091     2053      -38     
==========================================
+ Hits        14432    14551     +119     
- Misses       4592     4736     +144     
+ Partials       44       40       -4     
Flag Coverage Δ
summary 75.28% <100.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiv9604 shiv9604 force-pushed the bugfix/9054-inputcardgroup-info branch from 21c1b1f to 3581729 Compare September 21, 2024 12:18
Copy link

bundlemon bot commented Sep 21, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
292.67KB (+20B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.36KB +10%
demo/browser/runtime.(hash).js
42.88KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.1MB (+20B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix it differently and instead just add instanceof TemplateRef check in the docs to display "TemplateRef" instead of invoking toString

@shiv9604
Copy link
Contributor Author

Thanks for the suggestion @waterplea, I have resolved the PR comment. Please check.

@waterplea
Copy link
Collaborator

Thanks for the suggestion @waterplea, I have resolved the PR comment. Please check.

I meant to change it across all docs, not in this particular case. You can add a check here:
https://github.com/taiga-family/taiga-ui/blob/main/projects/addon-doc/components/documentation/pipes/inspect.pipe.ts#L25

return value instanceof TemplateRef ? 'TemplateRef' : tuiInspectAny(value, depth);

This way it will be fixed for such cases across all of the demo portal

@shiv9604
Copy link
Contributor Author

shiv9604 commented Oct 3, 2024

Thanks @waterplea, Suggestion was helpful and i have made the changes accordingly.

@splincode splincode requested a review from waterplea October 3, 2024 16:55
@waterplea waterplea merged commit 8417cea into taiga-family:main Oct 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Криво показывается инфа о InputCardGroup
3 participants