Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): fix re-creating main portal twice #9130

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore(demo): fix re-creating main portal twice #9130

merged 1 commit into from
Sep 23, 2024

Conversation

vladimirpotekhin
Copy link
Member

before:

  1. main portal creating twice when navigating to somewhere except landing-page route
Снимок экрана 2024-09-23 в 11 57 11
  1. main-portal unexpected creating on landing-page route
Снимок экрана 2024-09-23 в 11 57 44

Copy link

lumberjack-bot bot commented Sep 23, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 43fef93):

https://taiga-previews--pr9130-fix-doc-su2pw627.web.app

(expires Tue, 24 Sep 2024 09:21:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 23, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
42.32KB (-317B -0.73%) +10%
demo/browser/main.(hash).js
287.27KB (-591B -0.2%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.15KB +10%
demo/browser/styles.(hash).css
16.18KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change -908B -0.15%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.05MB (-73.19KB -1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit 5c49413 into main Sep 23, 2024
31 checks passed
@splincode splincode deleted the fix-doc branch September 23, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants