Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): sort icons are reversed #9904

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Dec 4, 2024

Fixes #9884

@hakimio hakimio requested a review from a team as a code owner December 4, 2024 08:04
@hakimio hakimio requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 4, 2024 08:04
Copy link

lumberjack-bot bot commented Dec 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.97KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.88KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.33MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@hakimio hakimio force-pushed the table-sort-icons branch 2 times, most recently from 74241d6 to ff76715 Compare December 4, 2024 08:40
@hakimio
Copy link
Contributor Author

hakimio commented Dec 6, 2024

@waterplea @vladimirpotekhin can you review the PR?

@splincode splincode added the community contribution This issue was closed by a PR from the community label Dec 9, 2024
@splincode splincode merged commit a6c0a36 into taiga-family:main Dec 9, 2024
23 of 25 checks passed
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4a26b1a) to head (f7e0a34).
Report is 769 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9904       +/-   ##
==========================================
- Coverage   75.68%       0   -75.69%     
==========================================
  Files        1216       0     -1216     
  Lines       19068       0    -19068     
  Branches     2091       0     -2091     
==========================================
- Hits        14432       0    -14432     
+ Misses       4592       0     -4592     
+ Partials       44       0       -44     
Flag Coverage Δ
summary ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

🐞 - Table sort icons in table header are reversed
4 participants