Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not update nx to v20.2.1 #9930

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

taiga-family-bot
Copy link
Collaborator

@taiga-family-bot taiga-family-bot commented Dec 6, 2024

This PR contains the following updates:

Package Type Change
@nx/angular (source) devDependencies 20.1.4 -> 20.2.1
@nx/cypress (source) devDependencies 20.1.4 -> 20.2.1
@nx/jest (source) devDependencies 20.1.4 -> 20.2.1
@nx/workspace (source) devDependencies 20.1.4 -> 20.2.1
nx (source) devDependencies 20.1.4 -> 20.2.1

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@taiga-family-bot taiga-family-bot requested a review from a team as a code owner December 6, 2024 02:09
@taiga-family-bot
Copy link
Collaborator Author

taiga-family-bot commented Dec 6, 2024

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @taiga-ui/[email protected]
npm error Found: @angular-devkit/[email protected]
npm error node_modules/@angular-devkit/build-angular
npm error   dev @angular-devkit/build-angular@"16.2.16" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular-devkit/build-angular@">= 17.0.0 < 20.0.0" from @nx/[email protected]
npm error node_modules/@nx/angular
npm error   dev @nx/angular@"20.2.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2024-12-10T06_52_18_688Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-10T06_52_18_688Z-debug-0.log

File name: undefined
Command failed: ws=$(node -p '!!require(`./package.json`).workspaces') && npm i -ws=$ws --include-workspace-root=$ws && npm i -ws=$ws --include-workspace-root=$ws
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @taiga-ui/[email protected]
npm error Found: @angular-devkit/[email protected]
npm error node_modules/@angular-devkit/build-angular
npm error   dev @angular-devkit/build-angular@"16.2.16" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular-devkit/build-angular@">= 17.0.0 < 20.0.0" from @nx/[email protected]
npm error node_modules/@nx/angular
npm error   dev @nx/angular@"20.2.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2024-12-10T06_53_04_596Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-12-10T06_53_04_596Z-debug-0.log

@taiga-family-bot taiga-family-bot requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 6, 2024 02:09
Copy link

lumberjack-bot bot commented Dec 6, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@taiga-family-bot taiga-family-bot force-pushed the renovate/dev-dependencies/nx branch 4 times, most recently from 05e2c0b to 8d11346 Compare December 7, 2024 02:27
@taiga-family-bot taiga-family-bot changed the title chore: update nx to v20.2.0 chore: update nx to v20.2.1 Dec 7, 2024
@taiga-family-bot taiga-family-bot force-pushed the renovate/dev-dependencies/nx branch from 8d11346 to 85433f9 Compare December 8, 2024 16:46
@taiga-family-bot taiga-family-bot changed the title chore: update nx to v20.2.1 chore: update nx to v20.2.1 - autoclosed Dec 8, 2024
@taiga-family-bot taiga-family-bot deleted the renovate/dev-dependencies/nx branch December 8, 2024 18:32
@taiga-family-bot taiga-family-bot restored the renovate/dev-dependencies/nx branch December 8, 2024 19:33
@taiga-family-bot taiga-family-bot changed the title chore: update nx to v20.2.1 - autoclosed chore: update nx to v20.2.1 Dec 8, 2024
@taiga-family-bot taiga-family-bot force-pushed the renovate/dev-dependencies/nx branch 7 times, most recently from c739fe3 to f53da7b Compare December 10, 2024 04:49
@splincode splincode force-pushed the renovate/dev-dependencies/nx branch from ff98542 to c576661 Compare December 10, 2024 07:03
@splincode splincode changed the title chore: update nx to v20.2.1 chore: do not update nx to v20.2.1 Dec 10, 2024
Copy link
Contributor

Visit the preview URL for this PR (updated for commit c576661):

https://taiga-previews-demo--pr9930-renovate-dev-dependencies-ddxvri96.web.app

(expires Wed, 11 Dec 2024 07:08:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (3bfee03) to head (c576661).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9930   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19607           
  Branches     2112     2079   -33     
=======================================
  Hits        14757    14757           
- Misses       4805     4806    +1     
+ Partials       45       44    -1     
Flag Coverage Δ
summary 75.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 10, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.94KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

passed  981 passed

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  8 minutes, 45 seconds
commit  c576661

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Automated approved)

Copy link
Collaborator

@taiga-family-approve-bot taiga-family-approve-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Automated approved)

@taiga-family-bot taiga-family-bot merged commit 8a5e9b2 into main Dec 10, 2024
30 checks passed
@taiga-family-bot taiga-family-bot deleted the renovate/dev-dependencies/nx branch December 10, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants