Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Tabs fix multiple emitting of activeItemIndexChange #9934

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #9805

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner December 6, 2024 14:27
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team December 6, 2024 14:27
Copy link

lumberjack-bot bot commented Dec 6, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Visit the preview URL for this PR (updated for commit 124f9f0):

https://taiga-previews-demo--pr9934-tabs-fix-demo-fl1q3n2e.web.app

(expires Sat, 07 Dec 2024 14:37:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 6, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.97KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.88KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +9B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.33MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Playwright test results

failed  1 failed
passed  974 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 32 seconds
commit  124f9f0

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /charts/ring-chart

@splincode splincode merged commit 4d4dbf1 into main Dec 8, 2024
26 of 27 checks passed
@splincode splincode deleted the tabs-fix branch December 8, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - TuiTabs (activeItemIndexChange) emits multiple times
3 participants