fix(kit): fix parallel lazy loading tree nodes #9939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node loading engine should not cancel the previous request, because these requests are for different nodes. If switchMap cancels a request, then the loading for the cancelled node is always running. https://t.me/taiga_ui/7924/25725
LeonidSimakov
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
waterplea
approved these changes
Dec 9, 2024
splincode
approved these changes
Dec 9, 2024
splincode
added
the
community contribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9939 +/- ##
==========================================
- Coverage 75.68% 0 -75.69%
==========================================
Files 1216 0 -1216
Lines 19068 0 -19068
Branches 2091 0 -2091
==========================================
- Hits 14432 0 -14432
+ Misses 4592 0 -4592
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node loading engine should not cancel the previous request, because these requests are for different nodes. If switchMap cancels a request, then the loading for the cancelled node is always running.
https://t.me/taiga_ui/7924/25725