Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): fix example #9943

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore(demo): fix example #9943

merged 1 commit into from
Dec 9, 2024

Conversation

waterplea
Copy link
Collaborator

Fixes #9940

@waterplea waterplea requested a review from a team as a code owner December 9, 2024 12:55
@waterplea waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 9, 2024 12:55
Copy link

lumberjack-bot bot commented Dec 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (332c32c) to head (e545e53).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9943   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files        1249     1249           
  Lines       19616    19616           
  Branches     1997     1979   -18     
=======================================
  Hits        14765    14765           
- Misses       4808     4809    +1     
+ Partials       43       42    -1     
Flag Coverage Δ
summary 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit e545e53):

https://taiga-previews-demo--pr9943-sheet-demo-5rnrniqb.web.app

(expires Tue, 10 Dec 2024 12:59:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 9, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.88KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea enabled auto-merge (squash) December 9, 2024 13:10
@waterplea waterplea merged commit 4d15317 into main Dec 9, 2024
28 checks passed
@waterplea waterplea deleted the sheet branch December 9, 2024 13:12
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Playwright test results

passed  978 passed

Details

report  Open report ↗︎
stats  978 tests across 69 suites
duration  8 minutes, 48 seconds
commit  e545e53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Top border of Input shadow overlaps hidden content in sheet dialog
3 participants