Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reuse method to destroy view #9949

Merged
merged 1 commit into from
Dec 12, 2024
Merged

refactor: reuse method to destroy view #9949

merged 1 commit into from
Dec 12, 2024

Conversation

splincode
Copy link
Member

No description provided.

@splincode splincode requested a review from a team as a code owner December 9, 2024 16:04
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 9, 2024 16:04
Copy link

lumberjack-bot bot commented Dec 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Visit the preview URL for this PR (updated for commit a7ddbf2):

https://taiga-previews-demo--pr9949-splincode-remove-demo-9bxtph56.web.app

(expires Tue, 10 Dec 2024 16:08:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (248e3d0) to head (a7ddbf2).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
projects/cdk/classes/portals.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9949   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19606    -1     
  Branches     2155     2146    -9     
=======================================
  Hits        14757    14757           
+ Misses       4804     4803    -1     
  Partials       46       46           
Flag Coverage Δ
summary 75.26% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 9, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.94KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Playwright test results

passed  981 passed

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  8 minutes, 44 seconds
commit  a7ddbf2

@splincode splincode merged commit 16c4f3a into main Dec 12, 2024
28 checks passed
@splincode splincode deleted the splincode/remove branch December 12, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants