Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): strange behavior in Safari when working with tiles #9952

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

reverie3
Copy link
Contributor

Fixes #9915

@reverie3 reverie3 requested a review from a team as a code owner December 10, 2024 07:25
@reverie3 reverie3 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 10, 2024 07:25
Copy link

lumberjack-bot bot commented Dec 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (4a26b1a) to head (861a318).
Report is 782 commits behind head on main.

Files with missing lines Patch % Lines
...ects/kit/components/tiles/tile-handle.directive.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9952      +/-   ##
==========================================
- Coverage   75.68%   75.26%   -0.43%     
==========================================
  Files        1216     1249      +33     
  Lines       19068    19607     +539     
  Branches     2091     2085       -6     
==========================================
+ Hits        14432    14757     +325     
- Misses       4592     4805     +213     
- Partials       44       45       +1     
Flag Coverage Δ
summary 75.26% <0.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 10, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.95KB (+11B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +11B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+11B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@reverie3
Copy link
Contributor Author

user-select: none does the trick as well, but Safari shows the text selection cursor. With preventDefault the cursor is consistent across all browsers.
image

@splincode splincode added contributions welcome Architecture is clear and community can help community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Dec 10, 2024
@splincode splincode merged commit 80614b3 into taiga-family:main Dec 10, 2024
27 checks passed
@splincode
Copy link
Member

@reverie3 could you add cherry-pick to v3.x branch?

reverie3 added a commit to reverie3/taiga-ui that referenced this pull request Dec 10, 2024
@reverie3
Copy link
Contributor Author

@reverie3 could you add cherry-pick to v3.x branch?

#9956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

🐞 - Strange behavior in Safari when working with tiles
3 participants