-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(demo): always check options by host in virtual scroll #9960
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9960 +/- ##
=======================================
Coverage 75.26% 75.26%
=======================================
Files 1249 1249
Lines 19607 19607
Branches 2112 2015 -97
=======================================
Hits 14757 14757
- Misses 4805 4807 +2
+ Partials 45 43 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit c375f36): https://taiga-previews-demo--pr9960-splincode-demo-issues-5725-505si6b0.web.app (expires Wed, 11 Dec 2024 16:38:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change -2B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test resultsDetails Open report ↗︎ Flaky testschromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click |
This doesn't really fix the issue. It makes virtual scroll recreate every item every time, which is ok here, but I think we should make it work for regular reusing mode too. That would require us to rethink the approach completely. I plan to do it when I refactor combo box to the new textfield so let's not merge this, otherwise I might forget :) |
Fixes #5725