Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): always check options by host in virtual scroll #9960

Closed
wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

Fixes #5725

@splincode splincode requested a review from a team as a code owner December 10, 2024 16:34
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 10, 2024 16:34
Copy link

lumberjack-bot bot commented Dec 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (3bfee03) to head (c375f36).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9960   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19607           
  Branches     2112     2015   -97     
=======================================
  Hits        14757    14757           
- Misses       4805     4807    +2     
+ Partials       45       43    -2     
Flag Coverage Δ
summary 75.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit c375f36):

https://taiga-previews-demo--pr9960-splincode-demo-issues-5725-505si6b0.web.app

(expires Wed, 11 Dec 2024 16:38:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 10, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.95KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

passed  980 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  8 minutes, 56 seconds
commit  c375f36

Flaky tests

chromium › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click

@waterplea
Copy link
Collaborator

This doesn't really fix the issue. It makes virtual scroll recreate every item every time, which is ok here, but I think we should make it work for regular reusing mode too. That would require us to rethink the approach completely. I plan to do it when I refactor combo box to the new textfield so let's not merge this, otherwise I might forget :)

@waterplea waterplea closed this Dec 12, 2024
@splincode splincode deleted the splincode/demo/issues/5725 branch December 12, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - paste selection does not work as expected in virtual scroll ComboBox
2 participants