Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-commerce): ThumbnailCard has new xs size #9969

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes TUIPRJ-251

TODO for proprietary repo (file overrides.less):

  • Set new value for --t-logo-height
  • Overrides bottom property for .t-logo & .t-content

@nsbarsukov nsbarsukov self-assigned this Dec 11, 2024
Copy link

lumberjack-bot bot commented Dec 11, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (035b2e1) to head (fc1ec3e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9969   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19607           
  Branches     2057     2022   -35     
=======================================
  Hits        14757    14757           
- Misses       4807     4808    +1     
+ Partials       43       42    -1     
Flag Coverage Δ
summary 75.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit fc1ec3e):

https://taiga-previews-demo--pr9969-thumbnail-card-design-spec-9ixrcbrd.web.app

(expires Thu, 12 Dec 2024 12:15:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 11, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.95KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+47B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

Playwright test results

failed  75 failed
passed  909 passed

Details

report  Open report ↗︎
stats  984 tests across 69 suites
duration  9 minutes, 6 seconds
commit  fc1ec3e

Failed tests

chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = l › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = s
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = xs
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = m › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = l › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = s
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › visa › size = xs
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = m › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 0000
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 1111
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 2222
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 3333
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 4444
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 5555
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 6666
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 7777
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 8888
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = l › 9999
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = s
chromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mir › size = xs
chromium › tests/core/surface/surface.pw.spec.ts › Surface › Layers
chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/thumbnail-card
chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/input-card-group
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/thumbnail-card
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/input-card
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/select
chromium › tests/demo/demo.pw.spec.ts › Demo › /layout/cell
chromium › tests/demo/demo.pw.spec.ts › Demo › /layout/card-medium
chromium › tests/legacy/select/select.pw.spec.ts › Select › Examples › checkmark size

@nsbarsukov nsbarsukov marked this pull request as ready for review December 11, 2024 12:37
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 11, 2024 12:37
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 11, 2024 12:37
@splincode splincode merged commit 436e351 into main Dec 11, 2024
27 of 28 checks passed
@splincode splincode deleted the thumbnail-card-design-spec branch December 11, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants