-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addon-commerce): ThumbnailCard
has new xs
size
#9969
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9969 +/- ##
=======================================
Coverage 75.26% 75.26%
=======================================
Files 1249 1249
Lines 19607 19607
Branches 2057 2022 -35
=======================================
Hits 14757 14757
- Misses 4807 4808 +1
+ Partials 43 42 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Visit the preview URL for this PR (updated for commit fc1ec3e): https://taiga-previews-demo--pr9969-thumbnail-card-design-spec-9ixrcbrd.web.app (expires Thu, 12 Dec 2024 12:15:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonUnchanged files (5)
Total files change -1B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test resultsDetails Open report ↗︎ Failed testschromium › tests/addon-commerce/thumbnail-card.pw.spec.ts › ThumbnailCard › Different width digits for different card sizes › mastercard › size = m › 0000 |
Fixes TUIPRJ-251
TODO for proprietary repo (file
overrides.less
):--t-logo-height
bottom
property for.t-logo
&.t-content