Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): skeleton animation speed slow down after speed up TUI_ANIMA… #9984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jonesso
Copy link

@Jonesso Jonesso commented Dec 13, 2024

Fixes #9778

@Jonesso Jonesso requested a review from a team as a code owner December 13, 2024 10:50
@Jonesso Jonesso requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 13, 2024 10:50
Copy link

lumberjack-bot bot commented Dec 13, 2024

Failed tests ❌

Before (main) ← Diff → After (local)

tests-demo-demo.pw-Demo-components-carousel-webkit-retry2/components-carousel/3.diff.png
tests-kit-carousel-carouse-a7c3c-d-show-next-item-after-drag-webkit-retry2/carousel-draggable.diff.png
tests-demo-demo.pw-Demo-charts-ring-chart-webkit-retry2/charts-ring-chart/2.diff.png

(updated for commit d1f9d74)

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.17%. Comparing base (f8ea2f2) to head (20ecd52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ects/kit/directives/skeleton/skeleton.directive.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9984   +/-   ##
=======================================
  Coverage   66.17%   66.17%           
=======================================
  Files        1214     1214           
  Lines       15702    15702           
  Branches     2284     2263   -21     
=======================================
  Hits        10391    10391           
- Misses       5063     5095   +32     
+ Partials      248      216   -32     
Flag Coverage Δ
summary 66.17% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 13, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
304.11KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -5B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.38MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

private readonly duration =
inject(TUI_ANIMATIONS_SPEED) * TUI_ANIMATIONS_DEFAULT_DURATION * 2;
private readonly duration = tuiGetDuration(
inject(TUI_ANIMATIONS_SPEED) * TUI_ANIMATIONS_DEFAULT_DURATION * 2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need TUI_ANIMATIONS_DEFAULT_DURATION, it is already there in tuiGetDuration. What was intended here, I believe, it to have duration twice longer than regular animations. So you need to change this to tuiGetDuration(inject(TUI_ANIMATION_SPEED) * 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - TuiSkeleton animation speed slow down after speed up TUI_ANIMATIONS_SPEED
3 participants