-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): skeleton animation speed slow down after speed up TUI_ANIMA… #9984
base: main
Are you sure you want to change the base?
Conversation
Failed tests ❌Before (main) ← Diff → After (local)tests-kit-carousel-carouse-a7c3c-d-show-next-item-after-drag-webkit-retry2/carousel-draggable.diff.png(updated for commit d1f9d74) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9984 +/- ##
=======================================
Coverage 66.17% 66.17%
=======================================
Files 1214 1214
Lines 15702 15702
Branches 2284 2263 -21
=======================================
Hits 10391 10391
- Misses 5063 5095 +32
+ Partials 248 216 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BundleMonUnchanged files (5)
Total files change -5B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
private readonly duration = | ||
inject(TUI_ANIMATIONS_SPEED) * TUI_ANIMATIONS_DEFAULT_DURATION * 2; | ||
private readonly duration = tuiGetDuration( | ||
inject(TUI_ANIMATIONS_SPEED) * TUI_ANIMATIONS_DEFAULT_DURATION * 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need TUI_ANIMATIONS_DEFAULT_DURATION
, it is already there in tuiGetDuration
. What was intended here, I believe, it to have duration twice longer than regular animations. So you need to change this to tuiGetDuration(inject(TUI_ANIMATION_SPEED) * 2
20ecd52
to
d1f9d74
Compare
Fixes #9778