Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9721 - Remove migrate tui-form classes from demo #9990

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shiv9604
Copy link
Contributor

Partially Fixes #9721

Description :

  1. Create example 2 in styles > foundations > form for migrating tui-form classes to form layout component.
  2. Add a deprecation warning.
  3. Shift the form component to layouts > form.
  4. Migrate remaining tui-form classes to form layout component

@shiv9604 shiv9604 self-assigned this Dec 15, 2024
@shiv9604 shiv9604 requested a review from a team as a code owner December 15, 2024 08:55
@shiv9604 shiv9604 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 15, 2024 08:55
Copy link

lumberjack-bot bot commented Dec 15, 2024

Failed tests ❌

Before (main) ← Diff → After (local)

tests-legacy-multi-select--6cf9b-log-with-tuiTextfieldSize-s-chromium-retry2/04-dialog-with-text-field-size-s.diff.png
tests-legacy-multi-select--e1648-log-with-tuiTextfieldSize-m-chromium-retry2/04-dialog-with-text-field-size-m.diff.png
tests-demo-demo.pw-Demo-components-carousel-webkit-retry2/components-carousel/3.diff.png
tests-demo-demo.pw-Demo-charts-ring-chart-webkit-retry2/charts-ring-chart/2.diff.png

(updated for commit cadf957)

@shiv9604 shiv9604 changed the title #9721 - Migrate tui-form classes from demo #9721 - Migrate tui-form classes from demo Dec 15, 2024
@shiv9604 shiv9604 changed the title #9721 - Migrate tui-form classes from demo #9721 - Remove migrate tui-form classes from demo Dec 15, 2024
Copy link

bundlemon bot commented Dec 15, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
43.98KB (+58B +0.13%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
304.11KB +10%
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +60B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.39MB (+14.59KB +0.19%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Demo should not use any of "tui-" classes other than spacings
1 participant