Skip to content

Commit

Permalink
ci: qemu-ppc64 bug has been fixed in QEMU 8.1.1
Browse files Browse the repository at this point in the history
  • Loading branch information
taiki-e committed Sep 11, 2023
1 parent 7448d01 commit 7b25950
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,7 @@ jobs:
- uses: taiki-e/setup-cross-toolchain-action@v1
with:
target: ${{ matrix.target }}
# TODO: QEMU 8.1 128-bit atomic bug in big endian powerpc64: https://gitlab.com/qemu-project/qemu/-/issues/1836
if: matrix.target != '' && !startsWith(matrix.target, 'powerpc64-')
- uses: taiki-e/setup-cross-toolchain-action@v1
with:
target: ${{ matrix.target }}
qemu: '8.0'
if: matrix.target != '' && startsWith(matrix.target, 'powerpc64-')
if: matrix.target != ''
- run: echo "RUSTFLAGS=${RUSTFLAGS} --cfg qemu" >>"${GITHUB_ENV}"
if: matrix.target != '' && !startsWith(matrix.target, 'i686') && !startsWith(matrix.target, 'x86_64')
- run: |
Expand Down
2 changes: 2 additions & 0 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ portable-atomic/

We mainly use QEMU to test for targets other than x86_64/aarch64, but some instructions do not work well in QEMU, so we sometimes use other tools. This section describes testing powerpc64le using IBM [POWER Functional Simulator](https://www.ibm.com/support/pages/node/6491145).

Note: Since QEMU 8.1.1, QEMU now supports all the instructions we use.

<!-- omit in toc -->
### Setup

Expand Down

0 comments on commit 7b25950

Please sign in to comment.