-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reference counted container #41
Conversation
It looks like, since embedded targets don't come with an allocator, building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great to me.
Hmm, it's failing on nightly when building with
Looks like, on BPF targets, the |
Ah, it's #29. Could you add portable-atomic/tools/build.sh Line 221 in a304903
|
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
bors r+ |
This pull requests resolves #37 by adding
Arc
andWeak
types to theportable-atomic-util
crate that useportable_atomic::AtomicUsize
in their operation. The goal is to allow for portable using ofArc
on platforms that may have allocation but not atomics. Arduino AVR comes to mind for this.These new types are based off of the ones in
libstd
, but I explicitly avoid using unstable features. I do not implement unstable functions, likenew_uninit
. I also avoided certain functions likenew_cyclic
andtake_mut
because I didn't get around to it.