Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): support delayed forced inclusion of txs #18826

Merged
merged 250 commits into from
Feb 6, 2025

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 23, 2025

Initial implementation of delayed inbox (forced inclusion of transactions)

The original idea is from @cyberhorsey's PR: https://github.com/taikoxyz/taiko-mono/pull/18824/files#diff-bea5dd46ba3d231a238b7c76adc7d09dfa3f8ebd3bf552407f9098492f3ff8f5

dantaik and others added 30 commits November 23, 2024 14:59
Co-authored-by: xiaodino <xiaodino@users.noreply.github.com>
Co-authored-by: xiaodino <xiaodino@users.noreply.github.com>
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
Co-authored-by: dantaik <dantaik@users.noreply.github.com>
Co-authored-by: xiaodino <xiaodino@users.noreply.github.com>
@dantaik dantaik enabled auto-merge (squash) February 5, 2025 03:31
@dantaik
Copy link
Contributor Author

dantaik commented Feb 5, 2025

This PR is ready for another round of review.

params.blocks[0].numTransactions = MAX_FORCED_TXS_PER_FORCED_INCLUSION;
}

params.blobParams.blobHashes = new bytes32[](1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set blobHashes here, then the _blobParams.firstBlobIndex will be ignored? https://github.com/taikoxyz/taiko-mono/blob/main/packages/protocol/contracts/layer1/based/TaikoInbox.sol#L568

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 94

            if (!calldataUsed) {
                if (params.blobParams.blobHashes.length == 0) {
                    require(params.blobParams.numBlobs != 0, BlobNotSpecified());
                } else {
                    require(
                        params.blobParams.numBlobs == 0 && params.blobParams.firstBlobIndex == 0,
                        InvalidBlobParams()
                    );
                }
            }
            ```

@dantaik dantaik changed the base branch from main to chore_protocol February 6, 2025 11:16
@dantaik dantaik merged commit 1ebc3cb into chore_protocol Feb 6, 2025
7 checks passed
@dantaik dantaik deleted the forced_tx_inclusion branch February 6, 2025 11:16
@dantaik dantaik restored the forced_tx_inclusion branch February 6, 2025 11:17
dantaik added a commit that referenced this pull request Feb 6, 2025
@dantaik dantaik deleted the forced_tx_inclusion branch February 6, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants