Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] flood_simulate (163), condemned_building (164) #80

Merged
merged 22 commits into from
Dec 9, 2023

Conversation

pigbearhsien
Copy link

@pigbearhsien pigbearhsien commented Nov 30, 2023

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request. Please provide enough information so that we can review your pull request.

Summary

Issue: closes #83

Added the two components detailed in Issue #83

Type (Fill in "x" to check)

  • Bug Fix
  • New Feature (Application)
  • New Feature (Chart / Map Type)
  • New Component

Checklist

Please make sure that all items are checked before submitting this request.

  • Code linter has been run and issues have all been resolved
  • The code has been thoroughly tested and no visible bugs have been introduced
  • The pull request will completely resolve the issue(s) mentioned
  • The pull request only resolves the issue(s) mentioned and nothing more

Attribution

Thanks for your hard work. If you will like to be attributed in all components that directly benefitted from your contribution, please check the box below.

  • I would like to be attributed

If this is your first time contributing, please fill in your (organization's) name, a profile image, and an optional link to your GitHub account or website.

112A

Additional context

N/A

@igorho2000 igorho2000 changed the title [Component] 163、164 [Component] flood_simulate (163), condemned_building (164) Dec 4, 2023
@igorho2000
Copy link
Collaborator

Thanks,

Per our previous discussion, please also rmbr to:

  • delete /csv
  • add the other geojsons for flood_simulate
  • open an issue regarding this PR and fill out each template
  • add your photos to /public/images/contributors for attribution
  • double check that all component info is provided and correct

Much appreciated, Igor

@igorho2000 igorho2000 self-requested a review December 8, 2023 01:29
@igorho2000 igorho2000 added the component Add a new component to the dashboard label Dec 8, 2023
Copy link
Collaborator

@igorho2000 igorho2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! LGTM

@igorho2000 igorho2000 merged commit 95d4336 into taipei-doit:main Dec 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Add a new component to the dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] 163 Flood Simulate / 164 Condemned Building
4 participants