TairString: support keepttl params

tair-opensource · Apr 10, 2023 · d6a1568 · d6a1568
1 parent 3dec818
commit d6a1568
Show file tree

Hide file tree

Showing 4 changed files with 77 additions and 0 deletions.
diff --git a/src/main/java/com/aliyun/tair/tairstring/params/ExincrbyFloatParams.java b/src/main/java/com/aliyun/tair/tairstring/params/ExincrbyFloatParams.java
@@ -19,6 +19,9 @@ public class ExincrbyFloatParams extends Params {
 
     private static final String MAX = "MAX";
     private static final String MIN = "MIN";
+
+    private static final String KEEPTTL = "keepttl";
+
     public ExincrbyFloatParams() {
     }
 
@@ -114,6 +117,15 @@ public ExincrbyFloatParams abs(long absoluteVersion) {
         return this;
     }
 
+    /**
+     * do not update ttl
+     * @return the params
+     */
+    public ExincrbyFloatParams keepttl() {
+        addParam(KEEPTTL);
+        return this;
+    }
+
     private void addParamWithValue(ArrayList<byte[]> byteParams, String option) {
         if (contains(option)) {
             byteParams.add(SafeEncoder.encode(option));
@@ -146,6 +158,10 @@ public byte[][] getByteParams(byte[]... args) {
         addParamWithValue(byteParams, MIN);
         addParamWithValue(byteParams, MAX);
 
+        if (contains(KEEPTTL)) {
+            byteParams.add(SafeEncoder.encode(KEEPTTL));
+        }
+
         return byteParams.toArray(new byte[byteParams.size()][]);
     }
 }
diff --git a/src/main/java/com/aliyun/tair/tairstring/params/ExincrbyParams.java b/src/main/java/com/aliyun/tair/tairstring/params/ExincrbyParams.java
@@ -23,6 +23,7 @@ public class ExincrbyParams extends Params {
 
     private static final String DEF = "def";
     private static final String NONEGATIVE = "nonegative";
+    private static final String KEEPTTL = "keepttl";
 
     public ExincrbyParams() {
     }
@@ -130,6 +131,15 @@ public ExincrbyParams abs(long absoluteVersion) {
         return this;
     }
 
+    /**
+     * do not update ttl
+     * @return the params
+     */
+    public ExincrbyParams keepttl() {
+        addParam(KEEPTTL);
+        return this;
+    }
+
     private void addParamWithValue(ArrayList<byte[]> byteParams, String option) {
         if (contains(option)) {
             byteParams.add(SafeEncoder.encode(option));
@@ -166,6 +176,10 @@ public byte[][] getByteParams(byte[]... args) {
 
         addParamWithValue(byteParams, DEF);
 
+        if (contains(KEEPTTL)) {
+            byteParams.add(SafeEncoder.encode(KEEPTTL));
+        }
+
         return byteParams.toArray(new byte[byteParams.size()][]);
     }
 }
diff --git a/src/main/java/com/aliyun/tair/tairstring/params/ExsetParams.java b/src/main/java/com/aliyun/tair/tairstring/params/ExsetParams.java
@@ -22,6 +22,7 @@ public class ExsetParams extends Params {
     private static final String MAX = "max";
 
     private static final String FLAGS = "flags";
+    private static final String KEEPTTL = "keepttl";
 
     /**
      * MEMCACHED: flags
@@ -109,6 +110,15 @@ public ExsetParams abs(long absoluteVersion) {
         return this;
     }
 
+    /**
+     * do not update ttl
+     * @return the params
+     */
+    public ExsetParams keepttl() {
+        addParam(KEEPTTL);
+        return this;
+    }
+
     private void addParamWithValue(ArrayList<byte[]> byteParams, String option) {
         if (contains(option)) {
             byteParams.add(SafeEncoder.encode(option));
@@ -142,6 +152,10 @@ public byte[][] getByteParams(String... args) {
 
         addParamWithValue(byteParams, FLAGS);
 
+        if (contains(KEEPTTL)) {
+            byteParams.add(SafeEncoder.encode(KEEPTTL));
+        }
+
         return byteParams.toArray(new byte[byteParams.size()][]);
     }
 
@@ -171,6 +185,10 @@ public byte[][] getByteParams(byte[]... args) {
 
         addParamWithValue(byteParams, FLAGS);
 
+        if (contains(KEEPTTL)) {
+            byteParams.add(SafeEncoder.encode(KEEPTTL));
+        }
+
         return byteParams.toArray(new byte[byteParams.size()][]);
     }
 }

diff --git a/src/test/java/com/aliyun/tair/tests/tairstring/TairStringTest.java b/src/test/java/com/aliyun/tair/tests/tairstring/TairStringTest.java
@@ -51,6 +51,35 @@ public void exsetTest() {
         assertEquals((long)1, bresult.getVersion());
     }
 
+    @Test
+    public void exsetKeepTTLTest() throws Exception{
+        ExsetParams params = new ExsetParams();
+        params.keepttl();
+        ExsetParams params_ex = new ExsetParams();
+        params_ex.ex(2);
+
+        // String
+        String ret = tairString.exset(key, value, params_ex);
+        assertEquals("OK", ret);
+        ret = tairString.exset(key, value);
+        assertEquals("OK", ret);
+        Thread.sleep(3000);
+        ExgetResult<String> getRet = tairString.exget(key);
+        assertEquals(value, getRet.getValue());
+        assertEquals(2, getRet.getVersion());
+
+        ret = tairString.exset(key, value, params_ex);
+        assertEquals("OK", ret);
+        ret = tairString.exset(key, value, params);
+        assertEquals("OK", ret);
+        getRet = tairString.exget(key);
+        assertEquals(value, getRet.getValue());
+        assertEquals(4, getRet.getVersion());
+        Thread.sleep(3000);
+        getRet = tairString.exget(key);
+        assertNull(getRet);
+    }
+
     @Test
     public void exsetParamsTest() {
         ExsetParams params_nx = new ExsetParams();