Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #123

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Improvements #123

merged 3 commits into from
Feb 9, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Feb 9, 2024

Changes:

  • do not have packaging hardcoded in source
  • mark two mojos as thread safe

@cstamas
Various improvements
7f1155b 
Changes:
* do not have packaging ID wired in
* mark two mojos as thread-safe
@cstamas
Undo last change
fb3517c
@cstamas cstamas self-assigned this Feb 9, 2024
wendigo
wendigo approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % commits should be squashed together

@cstamas
Copy link
Member Author

cstamas commented Feb 9, 2024

In this project we usually "squash and merge", so PR can have many commits, will end up squashed.

@cstamas cstamas merged commit 459caa0 into master Feb 9, 2024
3 checks passed
@cstamas cstamas deleted the improvements branch February 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstamas @wendigo