【軽PR】x_mallocの使用 & ファイル構成の変更
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moromin
reviewed
Oct 21, 2021
| SRC_PATHS = $(CUR_PATH) $(PARSER_PATH) $(LEXER_PATH) $(AST_PATH) $(UTILS_PATH) | ||
| WRAPPER_PATH= ../../wrapper | ||
|
|
||
| SRC_PATHS = $(CUR_PATH) $(PARSER_PATH) $(LEXER_PATH) $(AST_PATH) $(UTILS_PATH) $(WRAPPER_PATH) |
There was a problem hiding this comment.
Makefile的に、PARSER_PATHとかに../internal追加しなくてもinternalディレクトリ下のファイルってコンパイルできましたっけ？
クローンしてきてmake reしたら失敗したんですが、タクミさんの方ではコンパイルできました？
There was a problem hiding this comment.
すんません、コンパイルできるか確認してなかったです笑
修正したのでご確認お願いします！
moromin
approved these changes
Oct 21, 2021
| @@ -10,7 +10,7 @@ | |||
| #include <sys/ioctl.h> | |||
|
|
|||
| #include "libft/libft.h" | |||
| #include "parser/parser.h" | |||
| #include "parser/parse.h" | |||
| #include "lexer/lexer.h" | |||
| #include "expander/expander.h" | |||
| #include "execute/execute.h" | |||
There was a problem hiding this comment.
ディレクトリとヘッダ名は[verb-er]/[verb]の形で統一します？
There was a problem hiding this comment.
parse.hで宣言する関数がparse()だけだったので、parse.hにしました！
それで大丈夫でそうですか？
There was a problem hiding this comment.
個人的には、ディレクトリ名とヘッダ名を同じにした方が見やすい感はありますね
There was a problem hiding this comment.
関数名は動詞の方がいいですよね？lex()``parse()みたいな
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ファイル名とか変えちゃったので、見づらいかと思いますが、コード自体は特に変更していないので、軽くApprove頂けたらと思います！
Effect
minishell.cなどからはparse.hだけをインクルードするので、parser内部の処理で使っているその他の関数を使えないようにしている。モジュールに分けて処理が見られるようになるので、初見の人でも見やすく・考えやすくなるのでは？Memo
internalディレクトリは内部処理的な意味なので、このままでもいい気がしますが、ヘッダー名が悩み中です...