Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csv file fixes #2

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Csv file fixes #2

merged 3 commits into from
Mar 26, 2024

Conversation

talister
Copy link
Owner

Change Description

  • Allows the ability to pass units to read_element for use when reading CSV files so nm are not assumed.
  • Adds ZnSe transmission data
  • My PR includes a link to the issue that I am addressing

Solution Description

Checks for a passed value of wave_unit= that is not u.nm and passes the new unit to specio.read_ascii_spec() if this is the case

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@talister talister added bug Something isn't working enhancement New feature or request labels Mar 26, 2024
@talister talister self-assigned this Mar 26, 2024
@talister talister merged commit c58b280 into main Mar 26, 2024
6 checks passed
@talister talister deleted the csv_file_fixes branch March 26, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant