-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SuggestionFrame
#89
Conversation
Warning Rate Limit Exceeded@talmo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update introduces the handling of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 95.61% 95.68% +0.06%
==========================================
Files 14 15 +1
Lines 1665 1691 +26
==========================================
+ Hits 1592 1618 +26
Misses 73 73 ☔ View full report in Codecov by Sentry. |
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (8)
sleap_io/__init__.py (4)
Line range hint
3-3
: Consider removing or using the unused import__version__
.- from sleap_io.version import __version__
Line range hint
4-4
: Consider removing or using the unused importsNode
,Edge
,Skeleton
,Symmetry
.- from sleap_io.model.skeleton import Node, Edge, Skeleton, Symmetry
Line range hint
5-5
: Consider removing or using the unused importVideo
.- from sleap_io.model.video import Video
Line range hint
7-11
: Consider removing or using the unused importsPoint
,PredictedPoint
,Track
,Instance
,PredictedInstance
.- from sleap_io.model.instance import ( - Point, - PredictedPoint, - Track, - Instance, - PredictedInstance, - )tests/io/test_slp.py (2)
Line range hint
4-4
: Consider removing or using the unused importVideo
.- from sleap_io import Video
Line range hint
52-52
: Replace type comparison withisinstance()
for better practice and flexibility.- assert type(labels) == Labels + assert isinstance(labels, Labels)sleap_io/model/labels.py (1)
Line range hint
73-73
: Replace type comparison withisinstance()
for better practice and flexibility.- if type(key) == int: + if isinstance(key, int):sleap_io/io/slp.py (1)
Line range hint
27-29
: Consider removing or using the unused importswrite_hdf5_dataset
,write_hdf5_group
,write_hdf5_attrs
.- from sleap_io.io.utils import ( - write_hdf5_dataset, - write_hdf5_group, - write_hdf5_attrs, - )
from sleap_io import LabeledFrame, Instance, PredictedInstance, Video, Track | ||
from sleap_io import ( | ||
LabeledFrame, | ||
Instance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing or using the unused import Instance
.
- from sleap_io import Instance
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Instance, |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit
New Features
Labels
class to support a list of suggestion frames associated with datasets.Documentation