Resolve initial CI issues #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminob
force-pushed
the
bugfix/fix-ci-issues
branch
from
234b1a2 to
d00e5a5
Compare
Additionally, disable "performance-noexcept-move-constructor" which is an alias for "cppcoreguidelines-noexcept-move-operations".
taminob
force-pushed
the
bugfix/fix-ci-issues
branch
7 times, most recently
from
79958d8 to
82c056a
Compare
taminob
force-pushed
the
bugfix/fix-ci-issues
branch
6 times, most recently
from
01b2dbb to
870e19f
Compare
Ubuntu does not provide up-to-date packages and thus fails some CI tests like clang-tidy, build, etc. due to some missing flags and incompatible behavior.
At first, clang-tidy was ran with --fix and some final issues were manually resolved.
This is achieved by using the run-clang-tidy wrapper script.
taminob
force-pushed
the
bugfix/fix-ci-issues
branch
from
c24f8fe to
b9d2d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to get the CI green for the initial code.
This is achieved by applying auto-fixes of clang-tidy, manually resolving some issues and fixing the CI configurations.