Move include/ to include/ppplugin/ #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to avoid users of the library having to add include/ppplugin/ to the include path which may lead to confusing bugs with common header names. An alternative would be using a symlink include/ppplugin/ pointing to include/, but a circular symlink may cause issues in some obscure build system.
taminob
force-pushed
the
bugfix/move-include-dir
branch
from
ce3647a to
62a8123
Compare
If a simple "if" is used instead, the generated cmake target files will include the fmt dependency no matter what the surrounding "if" is evaluated to. With the generator expression, cmake can detect on generation of the files if the dependency should be included or not.
taminob
force-pushed
the
bugfix/move-include-dir
branch
from
62a8123 to
812be55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for the correct installation of the header files in
include/ppplugin/instead of directly in e.g./usr/include/.