This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
fix(server): fix bizarre duplicate logs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 84.34% 84.63% +0.28%
==========================================
Files 36 36
Lines 690 690
Branches 174 174
==========================================
+ Hits 582 584 +2
+ Misses 99 97 -2
Partials 9 9
Continue to review full report at Codecov.
|
I forgot to return after doing the query validation, so even if the query was found to be invalid it would still continue trying to serve the request using the same handler re #50
|
🎉 This PR is included in version 0.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to return after doing the query validation, so even if the query was found to be invalid it
would still continue trying to serve the request using the same handler
re #50