Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/change json #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor/change json #7

wants to merge 2 commits into from

Conversation

peepnoop
Copy link
Collaborator

Refactoring JSON to be more machine readable.

@gyamada619 Let me know your thoughts on the subunits where the code is the same as the parent unit. Currently they are assigned as CODE1 or CODE2.

@peepnoop peepnoop requested a review from gyamada619 October 14, 2022 15:52
gyamada619
gyamada619 requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@gyamada619 gyamada619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this thing - I'm a little apprehensive about "CLAG1" type entries, for example. That introduces complexity that isn't inherent to the upstream source.

@peepnoop
Copy link
Collaborator Author

I agree the CLAG1 was just a placeholder but in order to be a valid key it needs to be unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyamada619 gyamada619 gyamada619 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peepnoop @gyamada619