GUI v9.0 #28

Wang-yuanlu · 2024-06-04T12:23:36Z

Hi Mr.Tan.I added scrollbars to the cgraPannel, aligned the xbarButton and fuCheckButton in the parampannel module, and made some slight adjustments to the GUI to make it more useful."

tancheng

I remember you and MMJ mentioned that the compilation will also be fixed in this PR?

tancheng · 2024-06-05T04:48:22Z

launchUI.py

@@ -669,7 +669,7 @@ def leave(event):
 def clickTile(ID):
    widgets["fuConfigPannel"].config(text='Tile '+str(ID)+' functional units')
    widgets["xbarConfigPannel"].config(text='Tile '+str(ID)+' crossbar outgoing links')
-    widgets["xbarConfigPannel"].grid(columnspan=4, row=7, column=0,rowspan=2)
+    widgets["xbarConfigPannel"].grid(columnspan=4, row=7, column=0,rowspan=2,sticky="nsew")


Can you add a comment here about the meaning of "nsew"?

Yes. In this sentence "nsew" means that each xbar component will fill the corresponding grid space. Similar usage is seen in the subsequent code.

launchUI.py

tancheng · 2024-06-05T04:50:11Z

launchUI.py

-
+    spmLabel = tkinter.Button(canvas, text = "Data\nSPM", fg = 'black', bg = 'gray', relief = 'raised', bd = BORDER, command = clickSPM)
+    #button.place(height=memHeight, width=MEM_WIDTH, x = 25, y = 35)
+    canvas.create_window(baseX+BORDER, BORDER, window=spmLabel, height=GRID_HEIGHT, width=MEM_WIDTH, anchor="nw")


Can you add a comment explaining the anchor?

Comment on anchor.

Didn't see how this is resolved? Once you resolve a comment, can you please reply in this dialogue window (instead of just closing it), so it is more clear to the reviewer?

Sorry, I forgot this one. Here I use anchor="nw" to express that the data memory will be placed in the upper left corner of the cgrapannel. This way, it will be adaptive to changes in window size.

tancheng · 2024-06-05T04:53:03Z

launchUI.py

    widgets["spmConfigPannel"] = spmConfigPannel
    for i in range(3):
        spmConfigPannel.rowconfigure(i,weight=1)

-    spmConfigPannel.columnconfigure(0,weight=2)
+    spmConfigPannel.columnconfigure(0,weight=1)


Can you add a comment here about what are the columnconfigure used for?

Yes. Here the columnconfigure means that the spmConfigPannel will be evenly divided into three columns, and each column will fill the corresponding grid space.

launchUI.py

Wang-yuanlu · 2024-06-06T03:30:26Z

Hi Mr.Tan. I added comments to the code and modified the corresponding statements. I reviewed the execution method of launchUI.py in the ReadME file and I found that as long as I follow the steps in the original ReadME file, cd build, then python /WORK_REPO/CGRA-Flow/launchUI.py, the compile app function can be used normally.
Have a nice day!

tancheng

Hmmm, which kernel you tried to compile? It also failed on my machine/docker... (I also create build folder and typed python ../launchUI.py. Or do you mean we need to do python /WORK_REPO/CGRA-Flow/launchUI.py?

launchUI.py

Wang-yuanlu · 2024-06-11T09:14:14Z

Hi Mr.Tan.I have fine-tuned the initial size of the GUI to reduce redundant space. I adjusted the relative size of several functional modules and moved the tile's positions. For SPM, there were no y-axis coordinates in the initial setup so I chose to extend the height of SPM to accommodate different scales of CGRA. To ensure visual aesthetics, the size of the mapping section is not adjusted. I hope the adjustment is proper.
Have a nice day!

tancheng · 2024-06-11T14:54:20Z

Hi Yuanlu, thanks for taking care of my comments.
For the upper part size, I saw you increase the height of the SPM but didn't change the size of tile, which makes them not aligned with each other. Can you revert your changes for this? Let's make them align with each other.

You can see from the figure I attached, can we make the height of the upper part a little bit shorter (instead of just shortening the total window size)? Also, once you make the changes, can you please paste the screenshot here? Thanks.

Wang-yuanlu · 2024-06-12T02:07:04Z

Hi Mr.Tan. I reviewed the materials and adjusted some of the code contents. I divided the GUI interface into two rows. The following is the effect displayed on my computer. The cgrapanel contains additional components such as tiles and SPM. In order to ensure that the GUI has the ability to adapt to different scales of CGRA models, this panel is left with some gaps. I attempted to center these components and reduce the size of the gaps, but the effect was similar to the previous version. It was not very significant.

tancheng

Screenshot looks great to me. Just some nit to be fixed.

tancheng · 2024-06-12T03:14:12Z

launchUI.py

-        paramPannel.columnconfigure(i,weight=1)
+        paramPannel.rowconfigure(i, weight=1)
+    for i in range(3):
+        paramPannel.columnconfigure(i, weight=1) # Use columnconfigure and rowconfigure to partition the columns, so that each column and row will fill the corresponding space


Move comment above the code.

tancheng · 2024-06-12T03:15:43Z

launchUI.py

-            paramPannel.rowconfigure(i, weight=2)
-    for i in range(4):
-        paramPannel.columnconfigure(i,weight=1)
+        paramPannel.rowconfigure(i, weight=1)


Please comment on weight.

Okay. Here the entire paramPannel is divided into many rows and columns, and the weights are allocated according to the size of the components to be occupied. The “weight” represents the weight of the corresponding row/column length.

Ah, i mean add the comment above the corresponding code.

Okay I will do it.

There were some issues with my local environment, and a clash occurred, leading to an inability to sync the changes. I will submit the modified version in the future.

tancheng · 2024-06-12T03:17:41Z

launchUI.py

-
+    spmLabel = tkinter.Button(canvas, text = "Data\nSPM", fg = 'black', bg = 'gray', relief = 'raised', bd = BORDER, command = clickSPM)
+    #button.place(height=memHeight, width=MEM_WIDTH, x = 25, y = 35)
+    canvas.create_window(baseX+BORDER, BORDER, window=spmLabel, height=GRID_HEIGHT, width=MEM_WIDTH, anchor="nw")


Comment on anchor.

Didn't see how this is resolved? Once you resolve a comment, can you please reply in this dialogue window (instead of just closing it), so it is more clear to the reviewer?

tancheng · 2024-06-12T16:59:04Z

Sure, please let me do once the environment issue is fixed so we can merge.

tancheng · 2024-06-13T02:30:03Z

launchUI.py

@@ -1566,8 +1566,9 @@ def place_xbar_options(master):
 def create_param_pannel(master):
    paramPannel = tkinter.LabelFrame(master, text='Configuration', bd=BORDER, relief='groove')
    paramPannel.grid(row=0, column=1, rowspan=1, columnspan=1, sticky="nsew")
+
    # Use columnconfigure and rowconfigure to partition the columns, so that each column and row will fill the corresponding space


nit: period is missing at the end of comment.

Okay. I will add that period.

Wang-yuanlu · 2024-06-13T02:48:43Z

Hi, Mr Tan. I realized the format needs to be consistent so after checking all the added comments, I have unified them into a form without periods. I hope this time the file will look more fluid and aesthetically pleasing so that the subsequent merge and refinement can be more smooth.

tancheng · 2024-06-13T03:01:01Z

SG. Is the environment issue fixed on your side and we are ready to merge this PR?

Wang-yuanlu · 2024-06-13T03:03:48Z

SG. Is the environment issue fixed on your side and we are ready to merge this PR?

Yes. Yesterday the lab's server encountered a DNS pollution fault. I modified the host configuration file and now the environment on my side is back to normal.

tancheng · 2024-06-13T03:14:31Z

Cool, thanks!

GUI v9.0

50107c9

tancheng reviewed Jun 5, 2024

View reviewed changes

A graphical user interface for editing and designing.

df57729

tancheng reviewed Jun 6, 2024

View reviewed changes

launchUI.py Outdated Show resolved Hide resolved

launchUI.py Outdated Show resolved Hide resolved

launchUI.py Outdated Show resolved Hide resolved

launchUI.py Outdated Show resolved Hide resolved

A graphical user interface for editing and designing.

9457cfc

tancheng reviewed Jun 11, 2024

View reviewed changes

launchUI.py Outdated Show resolved Hide resolved

launchUI.py Outdated Show resolved Hide resolved

A graphical user interface for editing and designing.

544bb8d

A graphical user interface for editing and designing.

604f0a7

tancheng reviewed Jun 12, 2024

View reviewed changes

Wang-Yuanlu added 2 commits June 12, 2024 15:17

A graphical user interface for editing and designing.

fc33ab6

A graphical user interface for editing and designing.

86505c2

A graphical user interface for editing and designing.

0cf9e8e

tancheng reviewed Jun 13, 2024

View reviewed changes

Wang-Yuanlu added 2 commits June 13, 2024 10:36

A graphical user interface for editing and designing.

550ad6e

A graphical user interface for editing and designing.

b8cc0a0

tancheng merged commit a47448c into tancheng:master Jun 13, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GUI v9.0 #28

GUI v9.0 #28

Wang-yuanlu commented Jun 4, 2024

tancheng left a comment

tancheng Jun 5, 2024

Wang-yuanlu Jun 12, 2024

tancheng Jun 5, 2024

tancheng Jun 12, 2024 •

edited

Loading

Wang-yuanlu Jun 12, 2024

tancheng Jun 5, 2024

Wang-yuanlu Jun 12, 2024

Wang-yuanlu commented Jun 6, 2024

tancheng left a comment

Wang-yuanlu commented Jun 11, 2024

tancheng commented Jun 11, 2024

Wang-yuanlu commented Jun 12, 2024

tancheng left a comment

tancheng Jun 12, 2024

tancheng Jun 12, 2024

Wang-yuanlu Jun 12, 2024

tancheng Jun 12, 2024

Wang-yuanlu Jun 12, 2024

Wang-yuanlu Jun 12, 2024

tancheng Jun 12, 2024 •

edited

Loading

tancheng commented Jun 12, 2024

tancheng Jun 13, 2024

Wang-yuanlu Jun 13, 2024

Wang-yuanlu commented Jun 13, 2024

tancheng commented Jun 13, 2024

Wang-yuanlu commented Jun 13, 2024

tancheng commented Jun 13, 2024

GUI v9.0 #28

GUI v9.0 #28

Conversation

Wang-yuanlu commented Jun 4, 2024

tancheng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tancheng Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wang-yuanlu commented Jun 6, 2024

tancheng left a comment

Choose a reason for hiding this comment

Wang-yuanlu commented Jun 11, 2024

tancheng commented Jun 11, 2024

Wang-yuanlu commented Jun 12, 2024

tancheng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tancheng Jun 12, 2024 • edited Loading

Choose a reason for hiding this comment

tancheng commented Jun 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wang-yuanlu commented Jun 13, 2024

tancheng commented Jun 13, 2024

Wang-yuanlu commented Jun 13, 2024

tancheng commented Jun 13, 2024

tancheng Jun 12, 2024 •

edited

Loading

tancheng Jun 12, 2024 •

edited

Loading