Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2] Cleanup and update #39

Open
tancheng opened this issue Dec 11, 2024 · 6 comments
Open

[P2] Cleanup and update #39

tancheng opened this issue Dec 11, 2024 · 6 comments
Assignees
Labels
bug Something isn't working new feature New feature or request

Comments

@tancheng
Copy link
Owner

Deprecate en/rdy and use val/rdy for all modules.

@tancheng tancheng added the new feature New feature or request label Dec 11, 2024
@tancheng
Copy link
Owner Author

@RuihongY FYI.

@tancheng tancheng assigned yo96 and unassigned tancheng, yuqisun and yyan7223 Dec 23, 2024
@tancheng
Copy link
Owner Author

Hi @yo96, assigning this cleanup bug to you.

@tancheng
Copy link
Owner Author

The concrete TODOs:

  • Replace en/rdy with val/rdy
  • Resolve latches (provide initialization for all signals within a combinational block)
  • Update CGRA and PyOCN to latest PyMTL4.0 (or 3.0 whatever)
  • Make the xbar more modular rather than a behavioral-like design

@tancheng tancheng changed the title Replace en/rdy with val/rdy Cleanup and update Dec 23, 2024
@tancheng tancheng added bug Something isn't working help wanted labels Dec 24, 2024
@tancheng
Copy link
Owner Author

Hi @yo96, would following introduce combinational loop?

s.send_out[0].msg.predicate @= s.send_out[0].msg.predicate

in https://github.com/tancheng/VectorCGRA/blob/49a40187f90a8d67b0a410c0d3bc5944422e22e6/fu/single/AdderRTL.py#L104C9-L104C67

@yo96
Copy link
Collaborator

yo96 commented Dec 29, 2024

Yes, that looks like a combinational loop to me. It is like connecting the output of an AND gate to its input.

@tancheng tancheng changed the title Cleanup and update [P2] Cleanup and update Jan 3, 2025
@tancheng tancheng mentioned this issue Jan 3, 2025
4 tasks
@tancheng
Copy link
Owner Author

tancheng commented Jan 3, 2025

The concrete TODOs:

  • Replace en/rdy with val/rdy
  • Resolve latches (provide initialization for all signals within a combinational block)
  • Update CGRA and PyOCN to latest PyMTL4.0 (or 3.0 whatever)
  • Make the xbar more modular rather than a behavioral-like design

Updated:

  • Replace en/rdy with val/rdy: Separate xbar and replace en/rdy with val/rdy #54
  • Resolve latches (provide initialization for all signals within a combinational block)
  • Update CGRA and PyOCN to latest PyMTL4.0 (or 3.0 whatever)
  • Make the xbar more modular rather than a behavioral-like design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new feature New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants