Deleted HelloWorld, Metamask login. Moved Metamask button to fit in c… #1
Conversation
…ontainer that contains the logo, the branded text
| @@ -3,6 +3,8 @@ | |||
| ## Project setup | |||
| ``` | |||
| npm install | |||
| or dont | |||
| @@ -0,0 +1,6 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Do we need this file now? If not, delete for now.
| @@ -1,25 +1,32 @@ | |||
| <template> | |||
| <img alt="Vue logo" src="./assets/logo.png"> | |||
| <HelloWorld msg="Welcome to Your Vue.js App"/> | |||
There was a problem hiding this comment.
Let's leave HelloWorld in here for now as the landing page. That way, we can see how the Header acts on a page, instead of just seeing it in isolation. For example, if you do this:
`
|
|
||
| <b-navbar-button class="col"> | ||
| <li>{{ msg }}</li> | ||
| <button v-on:click="greet" class="enableEthereumButton">Connect</button> |
There was a problem hiding this comment.
At some point we'll probably want to pull this button (and the greet function) out into its own component. For now we can leave it like you have it.
| "core-js": "^3.6.5", | ||
| "vue": "^3.0.0", | ||
| "vue-fixed-header": "^3.2.15", |
There was a problem hiding this comment.
It seems like you're not using this, but using the bootstrap header instead? If thats true, remove this package.
| @@ -8,8 +8,11 @@ | |||
| "lint": "vue-cli-service lint" | |||
| }, | |||
| "dependencies": { | |||
| "@popperjs/core": "^2.9.2", | |||
There was a problem hiding this comment.
What's this for? Are we actually using it in this diff?
| @@ -8,8 +8,11 @@ | |||
| "lint": "vue-cli-service lint" | |||
| }, | |||
| "dependencies": { | |||
| "@popperjs/core": "^2.9.2", | |||
| "bootstrap": "^5.0.0", | |||
There was a problem hiding this comment.
Since we are downloading bootstrap from the CDN in public/index.html, we don't need to add it as a package here. Let's make a ticket now for converting from CDN usage to npm package usage later on.
deleted metamask component, and hello world componet.
combined both of 'em to fit within the header.vue component.
added some bootstrap packages for sticky-header.
logo added.
fonts added.