Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Amplitude Threshold #90 #97

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Anushka-Pote
Copy link
Contributor

@Anushka-Pote Anushka-Pote commented Nov 4, 2024

Description: Currently, the amplitude threshold for detecting sound is hard-coded. Implement a way for users to configure this threshold through an input prompt or command-line argument. This enhancement will allow users to customize the sensitivity of the sound detection to suit their specific needs.
Default - 20 value for Sus Calc
Issue number- #90
Contributor for- Gssoc-ext, Hacktoberfest

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@tanishaness tanishaness merged commit 5a3f89d into tanishaness:main Nov 8, 2024
1 check passed
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🎉🎉 Thank you for your contribution! Your PR #97 has been merged! 🎉🎉

@NK-Works
Copy link

NK-Works commented Nov 9, 2024

@Anushka-Pote i can work on it if you want
assign me

@Anushka-Pote
Copy link
Contributor Author

I would have loved to, but this PR is merged actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants