-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated English strings #2
base: master
Are you sure you want to change the base?
Conversation
I found and fixed some issues in the english translation.
@pmwoodward3 glad to see you, and in trans-string-en.js, the Sing out, Sing in, Sign up is origin from mean.js, and all route, controller method, api name are used these string, so i don't want to change it, but other trans all are very well, then how can i accept the Pull Request with out the Sign ** string? |
@pmwoodward3 I will try to use Commit Message Guidelines next commit, ;) |
@taobataoma is this still problematic to merge? I don't understand, why it should be a problem to change the english strings (the string vars aren't changed), when chinese does not use the english strings at all (and obviously still works). Should we rebase this commit on latest master and resubmit it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, definitely an improvement.
Why did you close this @katoxi ? |
I found and fixed some issues in the english translation.
Commit Message Guidelines