Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: support websocket stmt query #232

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

huskar-t
Copy link
Collaborator

@huskar-t huskar-t commented Jan 3, 2024

No description provided.

if err != nil {
return err
}
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to check the response?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be no response

taosWS/statement.go Outdated Show resolved Hide resolved
return
}
now := time.Now()
result, err := stmt.Exec(now, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, "binary", "nchar")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we insert many rows by call exec once?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a single SQL statement is allowed

@huskar-t huskar-t force-pushed the enh/xftan/TD-25351/wsstmt-3.0 branch from 8241706 to c71fda8 Compare January 5, 2024 06:26
Copy link
Contributor

@sheyanjie-qq sheyanjie-qq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huskar-t huskar-t merged commit c44aca7 into 3.0 Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants