init #51

menshibin · 2024-04-09T09:06:42Z

No description provided.

huskar-t · 2024-04-09T11:32:02Z

nodejs/src/client/wsClient.ts

+
+export class WsClient {
+    private _wsConnector?: WebSocketConnector;
+    private _req_id = 1000000;


huskar-t · 2024-04-09T11:32:19Z

nodejs/src/client/wsClient.ts

+    private _timeout?:number | undefined | null;
+    private _url:URL;


huskar-t · 2024-04-09T11:34:43Z

nodejs/package.json

+    "@types/jest": "^29.2.1",
+    "@types/json-bigint": "^1.0.1",
+    "@types/node": "^18.0.0",
+    "@types/websocket": "^1.0npm install async-mutex.5",


wrong version

huskar-t · 2024-04-09T11:36:39Z

nodejs/src/common/reqid.ts

@@ -0,0 +1,61 @@
+import { createHash } from 'crypto';
+import { v4 as uuidv4 } from 'uuid';


uuid not found

huskar-t · 2024-04-09T11:37:27Z

nodejs/src/common/taosResult.ts

+}
+
+export function readNchar(dataBuffer: ArrayBuffer, colDataHead: number, length: number): string {
+    let decoder = new TextDecoder();


huskar-t · 2024-04-09T11:38:05Z

nodejs/src/common/wsError.ts

+export class TaosResultError extends TDWebSocketClientError{};
+export class TaosError extends TDWebSocketClientError{};
+


Unnecessary semicolon

huskar-t · 2024-04-09T11:38:46Z

nodejs/src/common/wsError.ts

+    ERR_WEBSOCKET_CONNECTION = 104,
+    ERR_WEBSOCKET_QUERY_TIMEOUT = 105,
+    ERR_INVALID_AUTHENTICATION = 106,
+    ERR_UNSPPORTED_TDENGINE_TYPE = 107,


typo? unsupported?

huskar-t · 2024-04-09T11:39:28Z

nodejs/src/sql/wsRows.ts

+        try {
+            let wsFetchResponse = await this._wsClient.fetch(this._wsQueryResponse);
+            console.log("[wsQuery.execute.wsFetchResponse]==>\n", wsFetchResponse)
+            if (wsFetchResponse.completed == true) {


Can be simplified to wsFetchResponse.completed

huskar-t · 2024-04-09T11:39:43Z

nodejs/src/sql/wsRows.ts

+        }
+
+        this._taosResult = await this.getBlockData();
+        if (this._taosResult.GetData() == null) {


'if' statement can be simplified

huskar-t · 2024-04-09T11:40:22Z

nodejs/src/sql/wsSql.ts

+                try{
+                    while (true) {
+                        let wsFetchResponse = await this._wsClient.fetch(wsQueryResponse)
+                        if (wsFetchResponse.completed == true) {


Can be simplified to wsFetchResponse.completed

huskar-t · 2024-04-09T11:40:46Z

nodejs/src/sql/wsSql.ts

+                    let err :any = e
+                    throw new TaosResultError(err.code, err.message);
+                } finally {
+                    this._wsClient.freeResult(wsQueryResponse)


Missing await for an async function call ?

huskar-t · 2024-04-09T11:41:45Z

nodejs/src/tmq/config.ts

+    user: string;
+    password: string;
+    group_id: string;
+    clien_id: string;


huskar-t · 2024-04-10T01:22:13Z

nodejs/src/tmq/tmqResponse.ts

+
+}
+
+export class CommitedResp extends PartitionsResp {


huskar-t · 2024-04-10T01:22:53Z

nodejs/src/tmq/wsTmq.ts

+                var taosResults: Map<string, TaosResult> = new Map();
+                let resp = await this._wsClient.exec(JSON.stringify(queryMsg), false);
+                let pollResp = new WsPollResponse(resp)
+                if (pollResp.have_message == false || pollResp.message_type != TMQMessageType.ResDataType) {


Can be simplified to !pollResp.have_message

huskar-t · 2024-04-10T01:23:29Z

nodejs/src/tmq/wsTmq.ts

+                        // count++
+                        let fetchResp = await this.fetch(pollResp)
+                        if (fetchResp.completed || fetchResp.rows == 0) {
+                            let currTime = new Date().getTime();


huskar-t · 2024-04-10T01:24:53Z

nodejs/src/client/wsConnectorPool.ts

+    private static _instance?:WebSocketConnectionPool;
+    private pool: Map<string, WebSocketConnector[]> = new Map();
+    private  _connectionCount: number;
+    private  _maxConnections: number;


huskar-t · 2024-04-10T01:31:34Z

nodejs/src/sql/wsRows.ts

+            return
+        }
+        this._isClose = true
+        this._wsClient.freeResult(this._wsQueryResponse)


need .then()?

huskar-t · 2024-04-10T01:32:28Z

nodejs/src/sql/wsRows.ts

+
+export class WSRows {
+    private _wsClient: WsClient;
+    private _wsQueryResponse: WSQueryResponse;


huskar-t · 2024-04-10T01:34:00Z

nodejs/example/basicSql.ts

+            let result = await wsRows.GetData();
+            console.log('queryRes.Scan().then=>', result);
+        }
+        await wsRows.Close()


wrRows.Close is a synchronous function

huskar-t · 2024-04-10T01:35:37Z

nodejs/src/sql/wsSql.ts

+                            let tmp: TaosResult = await this._wsClient.fetchBlock(wsFetchResponse, taosResult);
+                            taosResult = tmp;


is redundant

huskar-t · 2024-04-10T01:36:27Z

nodejs/src/stmt/wsParams.ts

+    private precisionLength:number = PrecisionLength['ms']
+    private _params: ColumnInfo[];


huskar-t

see my comments

huskar-t · 2024-04-10T02:21:57Z

nodejs/src/common/taosResult.ts

+    public GetTotalTime() {
+        return this._totalTime;
+    }
+    public  AddtotalTime(totalTime:number) {


AddtotalTime -> AddTotalTime

huskar-t · 2024-04-10T02:31:50Z

need to format and add automatic tests

sheyanjie-qq · 2024-04-09T09:11:08Z

nodejs/example/basicSchemaless.ts

+import { sqlConnect } from '../index';
+let dsn = 'ws://root:[email protected]:6051/ws';
+let db = 'power'
+let influxdbData = "st,t1=3i64,t2=4f64,t3=\"t3\" c1=3i64,c3=L\"passit\",c2=false,c4=4f64 1626006833639000000";


尽量使用 meters 表做用例

sheyanjie-qq · 2024-04-09T09:19:36Z

nodejs/example/basicSql.ts

+import { WSConfig } from '../src/common/config';
+import { sqlConnect } from '../index'
+
+let dsn = 'ws://root:[email protected]:6051/ws';


最后的 ws 是数据库吗，如果不是，是端点，不要体现出来，Adapter 的路径对外不可见

sheyanjie-qq · 2024-04-09T09:22:07Z

nodejs/example/basicTmq.ts

+    [TMQConstants.CONNECT_PASS, "taosdata"],
+    [TMQConstants.AUTO_OFFSET_RESET, "earliest"],
+    [TMQConstants.CLIENT_ID, 'test_tmq_client'],
+    [TMQConstants.WS_URL, 'ws://192.168.1.95:6051/rest/tmq'],


rest/tmq 不要暴露

sheyanjie-qq · 2024-04-09T09:24:33Z

nodejs/readme.md

+- **host/port**: Declare host and port. eg. `localhost:6041`
+- **database**: Optional, use to specify database name.
+- **params**: Other parameters. Like cloud Token.
+


dsn 定义是对的，严格按照这个来解析

sheyanjie-qq · 2024-04-09T09:25:10Z

nodejs/readme.md

+
+``` typescript
+import {connect} from '@tdengine/websocket'
+let dsn = "ws://host:port/rest/ws/db"


这里跟上面 dsn 对不上

sheyanjie-qq · 2024-04-10T02:27:36Z

nodejs/src/sql/wsSql.ts

+        })
+    }
+
+    async execute(sql: string, reqId?: number, action:string = 'query'): Promise<TaosResult> {


schemaless 不支持sql

sheyanjie-qq · 2024-04-10T02:33:19Z

nodejs/src/stmt/wsParams.ts

+    }
+
+
+    private encodeColumnNumbers(params:any[], dataType:string = 'number', typeLen:number, columnType:number):[number, ArrayBuffer] {


方法名好像只处理 number 类型

sheyanjie-qq · 2024-04-10T02:43:41Z

nodejs/src/tmq/wsTmq.ts

+                    // let count = 0
+                    // let startTime = new Date().getTime();
+                    while (true) {
+                        // count++


无用代码都应该删除，不要注释掉

sheyanjie-qq · 2024-04-10T02:46:03Z

nodejs/test/bulkPulling/queryTables.test.ts

+            for (let i = 0; i < actualData.length; i++) {
+                actualData[i].forEach((d, index) => {
+                    if (expectMeta[index].name == 'geo' || expectMeta[index].name == 'vbinary') {
+                        expect(d).toBeTruthy()


为何这两种类型没有仔细检查？

sheyanjie-qq · 2024-04-10T02:48:34Z

nodejs/test/bulkPulling/schemaless.test.ts

+        wsSchemaless.Close();
+    });
+
+    test('normal wsSql insert', async() => {


这里都没有check

init

9ae4e2e

menshibin requested review from huskar-t and sheyanjie-qq April 9, 2024 09:06

huskar-t reviewed Apr 9, 2024

View reviewed changes

nodejs/src/tmq/config.ts Outdated

user: string;

password: string;

group_id: string;

clien_id: string;

Copy link

Contributor

huskar-t Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

huskar-t reviewed Apr 10, 2024

View reviewed changes

nodejs/src/tmq/tmqResponse.ts Outdated

}

export class CommitedResp extends PartitionsResp {

Copy link

Contributor

huskar-t Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

huskar-t reviewed Apr 10, 2024

View reviewed changes

huskar-t requested changes Apr 10, 2024

View reviewed changes

huskar-t reviewed Apr 10, 2024

View reviewed changes

sheyanjie-qq reviewed Apr 10, 2024

View reviewed changes

menshibin added 2 commits April 13, 2024 10:09

config ci workflows

381663b

modify reviw problems

3c53dbd

menshibin added 14 commits April 15, 2024 13:35

add workflows

7eb7003

modify workflows

12b6141

modify workflows

1191d20

modify workflows

0c30700

modify workflows

3f392b4

modify workflows

1b68699

modify workflows

56caee3

modify workflows

7a189c1

modify workflows

ae343e4

modify workflows

7bb9e20

modify test case ip

2f1697c

modify async function call

3d57856

modify tmq expect

802e705

modify tmq expect

325d52d

menshibin merged commit ed3b566 into main Apr 18, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

init #51

init #51

menshibin commented Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 9, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t Apr 10, 2024

huskar-t left a comment

huskar-t Apr 10, 2024

huskar-t commented Apr 10, 2024

sheyanjie-qq Apr 9, 2024

sheyanjie-qq Apr 9, 2024

sheyanjie-qq Apr 9, 2024

sheyanjie-qq Apr 9, 2024

sheyanjie-qq Apr 9, 2024

sheyanjie-qq Apr 10, 2024

sheyanjie-qq Apr 10, 2024

sheyanjie-qq Apr 10, 2024

sheyanjie-qq Apr 10, 2024

sheyanjie-qq Apr 10, 2024

		private _timeout?:number \| undefined \| null;
		private _url:URL;

		@@ -0,0 +1,61 @@
		import { createHash } from 'crypto';
		import { v4 as uuidv4 } from 'uuid';

		export class TaosResultError extends TDWebSocketClientError{};
		export class TaosError extends TDWebSocketClientError{};

		let tmp: TaosResult = await this._wsClient.fetchBlock(wsFetchResponse, taosResult);
		taosResult = tmp;

		private precisionLength:number = PrecisionLength['ms']
		private _params: ColumnInfo[];

		}


		private encodeColumnNumbers(params:any[], dataType:string = 'number', typeLen:number, columnType:number):[number, ArrayBuffer] {

init #51

init #51

Conversation

menshibin commented Apr 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huskar-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huskar-t commented Apr 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment