Add balancing test with discovery and connections #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtDu
force-pushed
the
more_balancing_tests
branch
2 times, most recently
from
aeeddd9 to
7f9bdf4
Compare
ArtDu
force-pushed
the
more_balancing_tests
branch
from
7f9bdf4 to
87468f9
Compare
akudiyar
requested changes
Apr 28, 2023
| "cartridge.admin_edit_topology({ replicasets = replicasets }) ").join(); | ||
|
|
||
| // wait until discovery get topology | ||
| Thread.sleep(5_000); |
There was a problem hiding this comment.
That seems highly unstable on different machines. Please use polling (until the cluster gets the proper state) over sleeping.
| assertEquals(Arrays.asList(4, 5), getCallCountersPerConnection(getAllConnectionCalls, router)); | ||
| } | ||
|
|
||
| Object routerCallCounterPerConnection = getCallCountersPerConnection(getAllConnectionCalls, routerClient4); |
There was a problem hiding this comment.
q: Why is it a raw Object?
| assertEquals(Arrays.asList(6, 7), getCallCountersPerConnection(getAllConnectionCalls, router)); | ||
| } | ||
|
|
||
| startCartridge(); |
|
|
||
| @NotNull | ||
| private static Object getCallCountersPerConnection(String getAllConnectionCalls, TarantoolClient router) { | ||
| List<?> luaResponse = router.eval(getAllConnectionCalls).join(); |
There was a problem hiding this comment.
Why isn't it a call or better callForSingleResult/callForMultiResult?
There was a problem hiding this comment.
We are showing the readers/users a bad code that they will copy to their projects
|
Also we could add parallel round-robin test |
ArtDu
force-pushed
the
more_balancing_tests
branch
from
9c4d441 to
c3a874c
Compare
|
Blocked by #400 |
ArtDu
added
blocked
ArtDu
force-pushed
the
master
branch
2 times, most recently
from
367fe33 to
f2c5fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues: