Optimize usage of the Netty's and MsgPack's buffers #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtDu
reviewed
Nov 10, 2023
akudiyar
changed the title
ArtDu
reviewed
Nov 24, 2023
ArtDu
approved these changes
Dec 5, 2023
ArtDu
previously requested changes
Dec 6, 2023
akudiyar
force-pushed
the
optimize-netty-handlers-tmp
branch
from
8d87026 to
86cc79a
Compare
Previously we were creating a new buffer and MsgPack packer on each request. This resulted in dramatic overload of GC with short-lived byte arrays. The new approach tries to maximize reusing of these byte arrays.
Previously the outbound requests were not flushed at all, causing memory overload as Netty does not flush the requests automatically as of version 4.1.x. But flushing each request will also affect the performance significantly, so the built-in batch flushing handler is added to the connection pipeline together with a config option for tuning the request batch size.
akudiyar
force-pushed
the
optimize-netty-handlers-tmp
branch
from
86cc79a to
f7e1267
Compare
Any Java exceptions that prevented connecting to the server were swallowed and only the exception name was printed. This patch adds logging of full stacktrace on connection exceptions.
akudiyar
force-pushed
the
optimize-netty-handlers-tmp
branch
from
f7e1267 to
42185ef
Compare
ArtDu
reviewed
Dec 28, 2023
ArtDu
approved these changes
Dec 28, 2023
|
The test changes were rewritten by subsequent updates unfortunately, will be added back in the upcoming PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were creating a new buffer and MsgPack packer on each request. This resulted in dramatic overload of GC with short-lived byte arrays. The new approach tries to maximize reusing of these byte arrays.