Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for AFTER crud operations option #456

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add example for AFTER crud operations option #456

merged 1 commit into from
Jan 23, 2024

Conversation

nickkkccc
Copy link
Contributor

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:
Closes #454

@nickkkccc nickkkccc requested review from akudiyar and ArtDu January 19, 2024 10:01
@nickkkccc nickkkccc self-assigned this Jan 19, 2024
@nickkkccc nickkkccc linked an issue Jan 19, 2024 that may be closed by this pull request
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only halfOfTupleCount sounds confusing, median is more suitable halfOfTupleCount

TarantoolResult<TarantoolTuple> resultAfterInsert = profileSpace.select(Conditions.any()).join();
assertEquals(tupleCount, resultAfterInsert.size());

final int halfOfTupleCount = tupleCount / 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final int halfOfTupleCount = tupleCount / 2;
final int median = tupleCount / 2;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

assertEquals(tupleCount, resultAfterInsert.size());

final int halfOfTupleCount = tupleCount / 2;
TarantoolTuple afterTuple = tupleFactory.create(halfOfTupleCount,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TarantoolTuple afterTuple = tupleFactory.create(halfOfTupleCount,
TarantoolTuple medianTuple = tupleFactory.create(halfOfTupleCount,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nickkkccc nickkkccc requested a review from ArtDu January 22, 2024 14:40
@nickkkccc nickkkccc added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 81655fe Jan 23, 2024
3 checks passed
@nickkkccc nickkkccc deleted the gh-454 branch January 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "after" CRUD operation option
2 participants