-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for AFTER crud operations option #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only halfOfTupleCount sounds confusing, median is more suitable halfOfTupleCount
TarantoolResult<TarantoolTuple> resultAfterInsert = profileSpace.select(Conditions.any()).join(); | ||
assertEquals(tupleCount, resultAfterInsert.size()); | ||
|
||
final int halfOfTupleCount = tupleCount / 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final int halfOfTupleCount = tupleCount / 2; | |
final int median = tupleCount / 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
assertEquals(tupleCount, resultAfterInsert.size()); | ||
|
||
final int halfOfTupleCount = tupleCount / 2; | ||
TarantoolTuple afterTuple = tupleFactory.create(halfOfTupleCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TarantoolTuple afterTuple = tupleFactory.create(halfOfTupleCount, | |
TarantoolTuple medianTuple = tupleFactory.create(halfOfTupleCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
I haven't forgotten about:
Related issues:
Closes #454