luarocks: fix usage of local configs #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR with update in tt: tarantool/tt#1004 |
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-load-local-files
branch
from
f673652 to
234a420
Compare
(cherry picked from commit c2c0272)
(cherry picked from commit 9751d99)
Skipping of load local configuration files will result in problems and loss of backward compatibility. Part of tarantool/tt#1003
It is not actually true. The config is loading. Part of tarantool/tt#1003
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-load-local-files
branch
from
234a420 to
0e8e0ec
Compare
(cherry picked from commit e3f067c)
|
It looks like tests are already broken by other commits. I suggest just to fix the issue here and do a proper rebase in #22 . |
DerekBum
approved these changes
Nov 11, 2024
|
It looks like there's too much work to do here. Let's just rebase to the latest version, see #24 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping of load local configuration files will result in problems and loss of backward compatibility.
Part of tarantool/tt#1003