api: add tls opts for listen field #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `http` module support tls, we need to update its dependency here. Part of #26
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
2 times, most recently
from
9f829f1 to
cb0de5d
Compare
themilchenko
requested review from
DifferentialOrange,
DerekBum and
oleg-jukovec
and removed request for
DifferentialOrange
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
2 times, most recently
from
b73f56b to
94aaf7f
Compare
There was a problem hiding this comment.
Please, add a test here too:
https://github.com/tarantool/metrics-export-role/blob/master/test/unit/http_test.lua
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
from
94aaf7f to
ecc7883
Compare
Added. |
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
from
ecc7883 to
61aa51a
Compare
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
from
61aa51a to
ea2932c
Compare
Since `metrics-export-role` support `listen` parameter, it is neccessary
to add tls opts for it. After the patch the following options `ssl_*`
were added. See an example as well:
```yaml
roles: [roles.metrics-export]
roles_cfg:
roles.metrics-export:
http:
- listen: 8081
ssl_key_file: "ssl_data/server.enc.key"
ssl_cert_file: "ssl_data/server.crt"
ssl_ca_file: "ssl_data/ca.crt"
ssl_ciphers: "ECDHE-RSA-AES256-GCM-SHA384"
ssl_password_file: "ssl_data/passwords"
endpoints:
- path: /metrics/json
format: json
- path: /metrics/prometheus/
format: prometheus
```
Closes #26
TLS doesn't work without tarantool built dynamically. After the patch build was changed in ci.
themilchenko
force-pushed
the
themilchenko/gh-26-add-tls-support
branch
from
ea2932c to
a1e6fea
Compare
oleg-jukovec
approved these changes
Dec 27, 2024
DerekBum
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
metrics-export-rolesupportlistenparameter, it is neccessary to add tls opts for it. After the patch the following optionsssl_*were added. See an example as well:Closes #26