Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arg to the config_schema.yml file for gzipped and hook up in run_stardis #116

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

jvshields
Copy link
Contributor

Allows the config to take a gzipped argument in model and passes that to the model reader.

This allows the config to point to any plane-parallel model obtained from https://marcs.oreme.org/

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #116 (faf3362) into main (437e371) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head faf3362 differs from pull request most recent head 679f54d. Consider uploading reports for the commit 679f54d to get more accurate results

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   33.89%   33.89%           
=======================================
  Files          17       17           
  Lines         658      658           
=======================================
  Hits          223      223           
  Misses        435      435           
Files Changed Coverage Δ
stardis/base.py 33.33% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonachitchyan
sonachitchyan previously approved these changes Aug 9, 2023
@jvshields jvshields added the benchmarks Trigger benchmarks to run on this pr label Aug 10, 2023
@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 10, 2023

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing main (437e371) and the latest commit (679f54d).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

All benchmarks:

All benchmarks:

     before           after         ratio
   [437e3711]       [679f54df]
     15.1±0.07s        15.4±0.1s     1.03  run_stardis.BenchmarkRunStardis.time_run_stardis

stardis/base.py Outdated Show resolved Hide resolved
@sonachitchyan sonachitchyan merged commit dc79d40 into tardis-sn:main Aug 11, 2023
6 checks passed
smokestacklightnin pushed a commit to smokestacklightnin/stardis that referenced this pull request Sep 20, 2023
…stardis (tardis-sn#116)

* add arg to the config_schema.yml file for gzipped and hook up in run_stardis

* remove comment about adding gzipped arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Trigger benchmarks to run on this pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants