Spherical #203
Spherical #203
Conversation
| w1[gap_index, nu_index] | ||
| * ( | ||
| ( | ||
| source[gap_index + 1, nu_index] |
There was a problem hiding this comment.
Some explanatory comments regarding the indices here would be nice. Or an equation reference.
There was a problem hiding this comment.
The equation reference is in the docstring. I think I didn't actually end up changing the raytracing equation other than not attentuating the ray for 0 optical depth. The rest of the equation just looks so different because black decided to format it differently this time for some reason I don't quite understand.
There was a problem hiding this comment.
On the note of indices though, do you think nu_index and gap_index aren't descriptive enough? I thought the names would be enough because they keep track of the gap in depth points you're moving past, or the frequency you're working on. But I've also been staring at this equation for months so I might be blind to it being unclear.
There was a problem hiding this comment.
Sorry, must have missed it in the docstring. The black formatting probably doesn't help either. The index names seem okay, though "gap" is not entirely clear to me. So you could either add the above as a descriptive comment, or find an alternative name.
|
I would just merge #212 instead of this. |
Somewhat working spherical geometry. Still needs validation/tests