fix: get sha3 mining working #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Main fix was getting dependency management right. There isn't _true_ automatic dep management. The `Session` struct has some boolean methods like `is_wallet_active()` that masks real dependencies. We should really have proper dependencies that don't rely on this hack. * Fixing configuration in config.toml Plenty of niggly settings (and many hours) to get this right. Sigh. * Automatically configuring the custom base node based on its pubkey. * Made node and wallet interactive so that `docker attach` works. This made debugging waaaaay easier. Added some other logs which could come out, or become trace in future.
CjS77
force-pushed
the
launch_containers
branch
from
f7f6eb8 to
055a623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't true automatic dep management. The
Sessionstruct has some boolean methods likeis_wallet_active()that masks real dependencies. We should really have proper dependencies that don't rely on this hack.Plenty of niggly settings (and many hours) to get this right. Sigh.
docker attachworks. This made debugging waaaaay easier.Added some other logs which could come out, or become trace in future.