refactor: libp2p #6630
Merged
refactor: libp2p #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617) feat: improve mempool error msg when mempool out of sync (tari-project#6618) feat: exit logic for pre-mine spend (tari-project#6615) chore: new release esme v1.6.0-pre.0 (tari-project#6614) feat: enable identity grpc method by default (tari-project#6613) feat: pre-mine introduce temp ban and add counters (tari-project#6612) chore: changes mainnet default network (tari-project#6610) chore(ci): add riscv64 builds and misc script fixes (tari-project#6611) feat!: esme test pre-mine with immediate spend (tari-project#6609) feat!: add context to ffi callbacks (tari-project#6608) feat: add default exclude dial (tari-project#6607) feat!: add input mr into genesis block (tari-project#6601) feat: update pre_mine specification (tari-project#6606)
* development: chore: new release esmeralda v1.7.0-pre.0 (tari-project#6625) fix: example mainnet config seed section (tari-project#6624) feat: improve base node connection from the wallet (tari-project#6619) chore: update pre mine funds (tari-project#6623) feat: upgrade utils (tari-project#6621) feat: update pre-mine specification (tari-project#6622) feat: add FFI function to create seed words from Mbase58 encrypted cipher seed (tari-project#6620)
ghpbot-tari-project
added
CR-too_long
* development: feat: add checked_sub (tari-project#6628)
Test Results (CI) 3 files 126 suites 11m 45s ⏱️ Results for commit 60e0fb5. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 10 suites +10 3h 8m 43s ⏱️ + 3h 8m 43s For more details on these failures, see this check. Results for commit 659172d. ± Comparison against base commit 47b4877. ♻️ This comment has been updated with latest results. |
* development: feat: add dns resiliency (tari-project#6629)
* development: chore: new release esmeralda v1.7.0-pre.2 (tari-project#6634) fix: view-only wallet scan (tari-project#6633) chore: new release esme ralda v1.7.0-pre.1 (tari-project#6631)
* development: feat: change ffi wallet recovery interface (tari-project#6636)
* development: test: add merge mining proxy monerod stress test code (tari-project#6639) test: add DammSum known-answer test (tari-project#6638) feat: add proxy monerod resiliency (tari-project#6637)
|
Hi Stan,
Will get to this tomorrow morning.
Regards,
Hansie.
…On Fri, 18 Oct 2024 at 11:21, Stan Bondi ***@***.***> wrote:
@sdbondi <https://github.com/sdbondi> requested review from
@tari-project/tari-core-developers on: #6630
<#6630> refactor: libp2p as a
code owner.
—
Reply to this email directly, view it on GitHub
<#6630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJKVKZTXZSHHBVWIIBEX3M3Z4DHKDAVCNFSM6AAAAABP63AH7GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUG4YTKOJWGA2TENA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Hansie Odendaal
Senior Rust Developer, Protocol
*Tari Labs (Pty) Ltd*
|
SWvheerden
reviewed
Oct 29, 2024
* development: fix(comms): ensure that inbound messaging terminates on disconnect (tari-project#6653) chore(deps): bump azure/trusted-signing-action from 0.4.0 to 0.5.0 (tari-project#6652) chore: new release esme v1.8.0-pre.0 (tari-project#6651) feat: close rpc connections when not in use - without close on dial requests (tari-project#6649) Update README.md with correct discord link (tari-project#6650) chore: new release esmeralda (tari-project#6647) chore: release new esmeralda v1.7.0-pre.3 (tari-project#6642)
|
@SWvheerden Thank you for the review! I've implemented some of the requested features. The message metrics are a little tougher, there are many ways to do it but I'd like to use libp2p metrics (to get libp2p metrics in general in addition to messaging metrics) but I'd need to upgrade metrics code since libp2p uses the prometheus-client 0.22 registry and we use an older version of prometheus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes