communicate takes bytes as inputs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, so why remove the |
|
Well I'm using python 3.5, and you need to remove encode for it to run. |
|
I agree with @thrasibule |
|
Can you make this PR pass tests on 3.4? If you want, also add a 3.5 test |
|
Fixed this in my PR. |
anthrotype
added a commit
to anthrotype/python-autopxd
that referenced
this pull request
Mar 24, 2018
python-autopxd already requires six, but the new `ensure_binary` function is only in the git repo and hasn't been released to PyPI yet, so I temporarily copied it here. The source comes from: benjaminp/six#204 It's a trivial function (every py2.py3 project has its own way to do the same thing). Fixes tarruda#12 Supersedes tarruda#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.