Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: from-deps: don't override all existing dependencies; don't add fetch entry for kinds without fetches #316

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix: from-deps: don't override all existing dependencies; don't add fetch entry for kinds without fetches #316

merged 2 commits into from
Aug 10, 2023

Commits on Aug 8, 2023

  1. fix: from-deps: don't override all existing dependencies; don't add f… 

    …etch entry for kinds without fetches

The former is arguably more than a "fix" in that it changes `from-deps` in a way that it is no longer the sole thing that manages upstream dependencies. In my opinion, if we are considering `from-deps` the official way to collect results from chunked/parallelized tasks, this is a necessary change, as we cannot predict the other things that such tasks may also depend on.

The latter is a pure bug fix: we shouldn't add a `fetch` block for kinds that have no `fetches` listed in `from-deps`.

(I can separate these two if it's useful.)
    @bhearsum
    bhearsum committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4a39ed1 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit.ci auto fixes [...]

    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1efe0d3 View commit details
    Browse the repository at this point in the history