Strip build- prefix from docker image task labels
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
added
the
BREAKING CHANGE
|
There's no rush on this, just wanted to tee it up for the next time we're doing a breaking change anyway. |
|
I guess this is to align with gecko? |
|
Yeah, it's blocking us consolidating the docker image logic as this prefix is hardcoded in a few places. I guess we could make it a configuration option, but I don't like that Taskgraph defaults to |
BREAKING CHANGE: `build-` prefix stripped from docker image tasks This is being done to facilitate merging some docker related logic with gecko_taskgraph. The issue with adding a `build-` prefix to the labels, is that it is common for there to exist a `build` kind. While it isn't best practice to parse labels to obtain information like the kind, in reality this happens pretty frequently. So making this change: 1. Makes the label consistent with Gecko (needed to merge some docker related logic) 2. Makes the label consistent with other tasks (prefix should just be the kind name) 3. Reduces footguns for folks that are parsing the label.
Opening file paths here results in an OSError in Gecko due to the large number of files involved in creating docker images there. The underlying tar writer accepts both file paths or file objects, so switch to paths to avoid the error in Gecko.
ahal
force-pushed
the
docker_image_name
branch
from
9a3f17b
to
9234c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.