Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add to docker howto #631

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

jcristau
Copy link
Contributor

Describe the parent, definition and args entries supported by the docker_image transforms.

@jcristau jcristau requested a review from ahal January 22, 2025 10:40
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for documenting this taskgraph-ism 🙂

To future readers: an external contributor asked a question about DOCKER_IMAGE_PARENT to @jcristau and me. That's what uncovered this lack of documentation.

Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is clearly an improvement so r+.

I do have some suggestions to make it even more useful though :)

docs/howto/docker.rst Outdated Show resolved Hide resolved
@jcristau jcristau force-pushed the docs-docker branch 3 times, most recently from 8461075 to ed2eeab Compare January 23, 2025 16:44
Describe the `parent`, `definition` and `args` entries supported by the
docker_image transforms.
@jcristau jcristau merged commit 949cbf8 into taskcluster:main Jan 24, 2025
15 checks passed
@jcristau jcristau deleted the docs-docker branch January 24, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants